Skip to content

Commit e66c774

Browse files
Fix leak in RestVectorTileAction
Fix obvious SearchResponse leak in RestVectorTileAction.
1 parent 3f20708 commit e66c774

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

x-pack/plugin/vector-tile/src/main/java/org/elasticsearch/xpack/vectortile/rest/RestVectorTileAction.java

+8-4
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,14 @@ public RestResponse buildResponse(SearchResponse searchResponse) throws Exceptio
162162
searchResponse.getShardFailures(),
163163
searchResponse.getClusters()
164164
);
165-
tileBuilder.addLayers(buildMetaLayer(meta, bounds, request, featureFactory));
166-
ensureOpen();
167-
tileBuilder.build().writeTo(bytesOut);
168-
return new RestResponse(RestStatus.OK, MIME_TYPE, bytesOut.bytes());
165+
try {
166+
tileBuilder.addLayers(buildMetaLayer(meta, bounds, request, featureFactory));
167+
ensureOpen();
168+
tileBuilder.build().writeTo(bytesOut);
169+
return new RestResponse(RestStatus.OK, MIME_TYPE, bytesOut.bytes());
170+
} finally {
171+
meta.decRef();
172+
}
169173
}
170174
}
171175
});

0 commit comments

Comments
 (0)