feat: add network interface capability #457
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // Copyright (c) 2025 Dell Inc, or its subsidiaries. | ||
|
|
||
| // Package netintf implements the network interface related CLI commands | ||
| package netintf | ||
|
|
||
| import ( | ||
| "context" | ||
| "log" | ||
|
|
||
| "github.com/opiproject/godpu/cmd/common" | ||
| network "github.com/opiproject/godpu/network" | ||
| "github.com/spf13/cobra" | ||
| "google.golang.org/protobuf/encoding/protojson" | ||
| ) | ||
|
|
||
| // ListNetworkInterfaces lists all Network Interface details from OPI server | ||
| func ListNetworkInterfaces() *cobra.Command { | ||
| var pageSize int32 | ||
| var pageToken string | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "list-net-interfaces", | ||
| Short: "List the network interfaces", | ||
| Run: func(c *cobra.Command, _ []string) { | ||
| addr, err := c.Flags().GetString(common.AddrCmdLineArg) | ||
| cobra.CheckErr(err) | ||
|
|
||
| timeout, err := c.Flags().GetDuration(common.TimeoutCmdLineArg) | ||
| cobra.CheckErr(err) | ||
|
|
||
| tlsFiles, err := c.Flags().GetString(common.TLSFiles) | ||
| cobra.CheckErr(err) | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), timeout) | ||
|
|
||
| netifClient, err := network.NewNetInterface(addr, tlsFiles) | ||
| if err != nil { | ||
| log.Fatalf("could not create gRPC client: %v", err) | ||
| } | ||
| defer cancel() | ||
|
There was a problem hiding this comment. would it make sense to create There was a problem hiding this comment. Will look at this one to determine if it needs to move or change in future addition. |
||
|
|
||
| for { | ||
| resp, err := netifClient.ListNetInterfaces(ctx, pageSize, pageToken) | ||
| if err != nil { | ||
| log.Fatalf("Failed to get items: %v", err) | ||
| } | ||
|
|
||
| // Process the response | ||
| log.Println("List Network Interfaces:") | ||
| for _, lif := range resp.NetInterfaces { | ||
| log.Println("Interface with: ") | ||
| common.PrintResponse(protojson.Format(lif)) | ||
| } | ||
|
|
||
| // Are there more pages | ||
| if resp.NextPageToken == "" { | ||
| // if no then break | ||
| break | ||
| } | ||
| // update to next token | ||
| pageToken = resp.NextPageToken | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().Int32VarP(&pageSize, "pagesize", "s", 0, "Specify page size") | ||
| cmd.Flags().StringVarP(&pageToken, "pagetoken", "t", "", "Specify the token") | ||
|
|
||
| return cmd | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // Copyright (c) 2022-2023 Intel Corporation, or its subsidiaries. | ||
| // Copyright (c) 2024 Dell Inc, or its subsidiaries. | ||
|
|
||
| // Package network implements the network related CLI commands | ||
| package network | ||
|
|
||
| import ( | ||
| "log" | ||
| "time" | ||
|
|
||
| "github.com/opiproject/godpu/cmd/common" | ||
| "github.com/opiproject/godpu/cmd/network/evpn" | ||
| "github.com/opiproject/godpu/cmd/network/netintf" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| // NewNetworkCommand tests the Network functionality command | ||
| func NewNetworkCommand() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "network", | ||
| Aliases: []string{"g"}, | ||
| Short: "Tests DPU networking functionality", | ||
| Args: cobra.NoArgs, | ||
| Run: func(cmd *cobra.Command, _ []string) { | ||
| err := cmd.Help() | ||
| if err != nil { | ||
| log.Fatalf("[ERROR] %s", err.Error()) | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| flags := cmd.PersistentFlags() | ||
| flags.Duration(common.TimeoutCmdLineArg, 10*time.Second, "timeout for a cmd") | ||
|
|
||
| cmd.AddCommand(NewEvpnCommand()) | ||
| cmd.AddCommand(NewNetIntfCommand()) | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| // NewNetIntfCommand tests the Network functionality command | ||
| func NewNetIntfCommand() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "intf", | ||
| Aliases: []string{"g"}, | ||
| Short: "Tests DPU network interface functionality", | ||
| Args: cobra.NoArgs, | ||
| Run: func(cmd *cobra.Command, _ []string) { | ||
| err := cmd.Help() | ||
| if err != nil { | ||
| log.Fatalf("[ERROR] %s", err.Error()) | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| flags := cmd.PersistentFlags() | ||
| flags.Duration(common.TimeoutCmdLineArg, 10*time.Second, "timeout for a cmd") | ||
|
|
||
| cmd.AddCommand(netintf.ListNetworkInterfaces()) | ||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| // NewEvpnCommand tests the EVPN functionality command | ||
| func NewEvpnCommand() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "evpn", | ||
| Aliases: []string{"g"}, | ||
| Short: "Tests DPU evpn functionality", | ||
| Args: cobra.NoArgs, | ||
| Run: func(cmd *cobra.Command, _ []string) { | ||
| err := cmd.Help() | ||
| if err != nil { | ||
| log.Fatalf("[ERROR] %s", err.Error()) | ||
| } | ||
| }, | ||
| } | ||
| // Bridge cli's | ||
| cmd.AddCommand(evpn.CreateLogicalBridge()) | ||
| cmd.AddCommand(evpn.DeleteLogicalBridge()) | ||
| cmd.AddCommand(evpn.GetLogicalBridge()) | ||
| cmd.AddCommand(evpn.ListLogicalBridges()) | ||
| cmd.AddCommand(evpn.UpdateLogicalBridge()) | ||
| // Port cli's | ||
| cmd.AddCommand(evpn.CreateBridgePort()) | ||
| cmd.AddCommand(evpn.DeleteBridgePort()) | ||
| cmd.AddCommand(evpn.GetBridgePort()) | ||
| cmd.AddCommand(evpn.ListBridgePorts()) | ||
| cmd.AddCommand(evpn.UpdateBridgePort()) | ||
| // VRF cli's | ||
| cmd.AddCommand(evpn.CreateVRF()) | ||
| cmd.AddCommand(evpn.DeleteVRF()) | ||
| cmd.AddCommand(evpn.GetVRF()) | ||
| cmd.AddCommand(evpn.ListVRFs()) | ||
| cmd.AddCommand(evpn.UpdateVRF()) | ||
| // SVI cli's | ||
| cmd.AddCommand(evpn.CreateSVI()) | ||
| cmd.AddCommand(evpn.DeleteSVI()) | ||
| cmd.AddCommand(evpn.GetSVI()) | ||
| cmd.AddCommand(evpn.ListSVIs()) | ||
| cmd.AddCommand(evpn.UpdateSVI()) | ||
|
|
||
| return cmd | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium