Restore 100% coverage

Author: RoyEJohnson

src/app/models/give-today.ts

@@ -1,8 +1,6 @@
 import cmsFetch from '~/helpers/cms-fetch';
 import {useDataFromPromise} from '~/helpers/page-data-utils';
 
-const promise = cmsFetch('give-today');
-
 type PromiseData = {
     give_link_text: string;
     give_link: string;
@@ -31,7 +29,7 @@ export default function useGiveToday(): Partial<GiveToday> {
         menu_expires: string;
         start: string;
         expires: string;
-    }>(promise);
+    }>(cmsFetch('give-today'));
 
     return giveData ? {
         ...giveData,

test/helpers/fetch-mocker.js

@@ -80,6 +80,7 @@ global.fetch = jest.fn().mockImplementation((...args) => {
     const isImage = args[0].includes('/api/images/');
     const isNewSubjects = args[0].includes('new-subjects');
     const isOsNews = (/openstax-news/).test(args[0]);
+    const isOxMenus = args[0].includes('/oxmenus/');
     const isPartner = (/pages\/partners/).test(args[0]);
     const isPolishPhysics = (/fizyka/).test(args[0]);
     const isPress = (/api\/press\/\?/).test(args[0]);
@@ -169,6 +170,8 @@ global.fetch = jest.fn().mockImplementation((...args) => {
                 payload = bookTitleData;
             } else if (isOsNews) {
                 payload = osNewsData;
+            } else if (isOxMenus) {
+                payload = [];
             } else if (isBlogArticle) {
                 payload = blogArticleData;
             } else if (isTeam) {

test/src/components/shell/header-menus.test.tsx

@@ -2,33 +2,44 @@ import React from 'react';
 import {describe, it, expect} from '@jest/globals';
 import {render, screen} from '@testing-library/preact';
 import Menus from '~/layouts/default/header/menus/menus';
-import {MemoryRouter} from 'react-router-dom';
+import MemoryRouter from '~/../../test/helpers/future-memory-router';
 import userEvent from '@testing-library/user-event';
-import useGiveToday from '~/models/give-today';
+import * as PDU from '~/helpers/page-data-utils';
+import * as CF from '~/helpers/cms-fetch';
 
-global.fetch = jest.fn().mockImplementation(() => {
-    return Promise.resolve({
-        json() {
-            return [];
-        }
-    });
-});
+/* eslint-disable camelcase */
+
+const mockUseDataFromPromise = jest.spyOn(PDU, 'useDataFromPromise');
+const giveTodayData = {
+    give_link_text: 'Give',
+    give_link: 'https://riceconnect.rice.edu/donation/support-openstax-header',
+    start: '2023-04-04T05:00:00Z',
+    expires: '2023-04-05T05:00:00Z',
+    menu_start: '2023-12-14T06:00:00Z',
+    menu_expires: '2024-04-01T23:00:00Z'
+};
+const futureDate = new Date(Date.now() + 500000).toLocaleString();
 
-jest.mock('~/models/give-today', () => jest.fn());
+jest.spyOn(CF, 'default').mockReturnValue(Promise.resolve({}));
 
 describe('shell/header/menus', () => {
     const user = userEvent.setup();
 
+    // eslint-disable-next-line complexity
     it('renders', async () => {
-        (useGiveToday as jest.Mock).mockReturnValue({
-            showButton: true
+        mockUseDataFromPromise.mockReturnValueOnce({
+            ...giveTodayData,
+            menu_expires: futureDate
         });
         render(
             <MemoryRouter initialEntries={['/']}>
                 <Menus />
             </MemoryRouter>
         );
-        expect(screen.getAllByRole('listitem')).toHaveLength(16);
+        const listitems = screen.queryAllByRole('listitem');
+
+        // The desktop Give menu item is off; Give button shows instead
+        expect(listitems.filter((i) => i.textContent === 'Give').length).toBe(1);
         const button = screen.getByRole('button');
 
         expect(screen.getAllByRole('menuitem')).toHaveLength(2);
@@ -55,14 +66,17 @@ describe('shell/header/menus', () => {
         expect(button.parentElement?.classList.contains('active')).toBe(true);
     });
     it('handles upper menus without Give', () => {
-        (useGiveToday as jest.Mock).mockReturnValue({
-            showButton: false
+        mockUseDataFromPromise.mockReturnValueOnce({
+            ...giveTodayData
         });
         render(
             <MemoryRouter initialEntries={['/']}>
                 <Menus />
             </MemoryRouter>
         );
-        expect(screen.getAllByRole('listitem')).toHaveLength(18);
+        const listitems = screen.queryAllByRole('listitem');
+
+        // No Give button, so Give menu item in both desktop and mobile
+        expect(listitems.filter((i) => i.textContent === 'Give').length).toBe(2);
     });
 });

test/src/data/webinars.ts

@@ -33,7 +33,8 @@ const pastWebinar: Webinar = {
 
 const pageData = {
     title: 'Webinar title',
-    heading: 'Webinar heading'
+    heading: 'Webinar heading',
+    webinars: []
 };
 
 export {upcomingWebinar, pastWebinar, pageData};

test/src/helpers/link.test.ts

@@ -33,3 +33,10 @@ describe('stripOpenStaxDomain', () => {
         expect(linkHelper.validUrlClick({target: el} as unknown as React.MouseEvent)).toBe(false);
     });
 });
+describe('logoutLink', () => {
+    it('generates a logoutLink', () => {
+        const link = linkHelper.logoutLink();
+
+        expect(link).toMatch('accounts/logout');
+    });
+});

test/src/pages/webinars/main-page.test.tsx

@@ -1,10 +1,11 @@
 import React from 'react';
 import {describe, expect, it} from '@jest/globals';
 import {render, screen} from '@testing-library/preact';
-import {MemoryRouter} from 'react-router-dom';
+import MemoryRouter from '~/../../test/helpers/future-memory-router';
 import {RouterContextProvider} from '~/components/shell/router-context';
 import MainPage from '~/pages/webinars/main-page/main-page';
-import useWebinarContext from '~/pages/webinars/webinar-context';
+import * as UWC from '~/pages/webinars/webinar-context';
+import * as UDH from '~/helpers/use-document-head';
 import {pageData} from '../../data/webinars';
 
 function Component() {
@@ -17,12 +18,22 @@ function Component() {
     );
 }
 
-jest.mock('~/pages/webinars/webinar-context', () => jest.fn());
+const mockUseWebinarContext = jest.spyOn(UWC, 'default');
+
+jest.spyOn(UDH, 'default').mockImplementation(
+    () => null
+);
 
 describe('webinars main page', () => {
     it('renders the main page', () => {
-        (useWebinarContext as jest.Mock).mockReturnValue({
-            pageData
+        mockUseWebinarContext.mockReturnValue({
+            pageData,
+            past: [],
+            upcoming: [],
+            subjects: [],
+            collections: [],
+            searchFor: jest.fn(),
+            latestWebinars: []
         });
         render(<Component />);
         expect(screen.getByText(pageData.heading)).toBeTruthy();

test/src/pages/webinars/search-page.test.tsx

@@ -1,11 +1,12 @@
 import React from 'react';
 import {describe, expect, it} from '@jest/globals';
 import {render, screen} from '@testing-library/preact';
-import {MemoryRouter} from 'react-router-dom';
+import MemoryRouter from '~/../../test/helpers/future-memory-router';
 import {RouterContextProvider} from '~/components/shell/router-context';
 import SearchPage from '~/pages/webinars/search-page/search-page';
-import useFetchedData from '~/helpers/use-data';
+import * as UFD from '~/helpers/use-data';
 import {upcomingWebinar} from '../../data/webinars';
+import * as UWC from '~/pages/webinars/webinar-context';
 
 function Component({term = ''}: {term?: string}) {
     return (
@@ -17,25 +18,36 @@ function Component({term = ''}: {term?: string}) {
     );
 }
 
+jest.spyOn(UWC, 'default').mockReturnValue({
+    pageData: {},
+    past: [],
+    upcoming: [],
+    subjects: [],
+    collections: [],
+    searchFor: jest.fn(),
+    latestWebinars: []
+});
+
 jest.mock('~/helpers/use-data', () => jest.fn());
+const mockUseFetchedData = jest.spyOn(UFD, 'default');
 
 describe('webinar search page', () => {
     it('short circuits while waiting for webinars to return', () => {
-        (useFetchedData as jest.Mock).mockReturnValue(undefined);
+        mockUseFetchedData.mockReturnValue(undefined);
         render(<Component term='waiting' />);
 
         expect(screen.queryByText('matching')).toBeNull();
     });
     it('displays a message when search returns no results', () => {
-        (useFetchedData as jest.Mock).mockReturnValue([]);
+        mockUseFetchedData.mockReturnValue([]);
         render(<Component term='xnotfoundx' />);
 
         expect(screen.getByText('No matching webinars found')).toBeTruthy();
     });
     it('displays results when they are returned', () => {
         // For code coverage
-        (useFetchedData as jest.Mock).mockImplementation(({postProcess}) => {
-            postProcess(upcomingWebinar);
+        mockUseFetchedData.mockImplementation(({postProcess}) => {
+            postProcess?.(upcomingWebinar);
             return [upcomingWebinar];
         });
         render(<Component term='something' />);