Add Custom Faiss Base Image Build Code #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Rajrahane
requested review from
navneet1v,
yigithub,
vamshin,
jed326,
rchitale7,
owenhalpert and
neetikasinghal
as code owners
|
Fixed the build-docker-image.sh line 45 to |
jed326
requested changes
Feb 19, 2025
navneet1v
reviewed
Feb 27, 2025
custom-faiss-installed-image/0001-added-commit-to-enable-the-add_with_ids-function-on-.patch
Outdated
Show resolved
Hide resolved
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Rajrahane
force-pushed
the
custom-faiss-installed-image
branch
from
9cce280 to
1de78b0
Compare
Signed-off-by: Rajvaibhav Rahane <[email protected]>
navneet1v
approved these changes
Mar 19, 2025
navneet1v
previously approved these changes
Mar 19, 2025
jed326
reviewed
Mar 19, 2025
Signed-off-by: Rajvaibhav Rahane <[email protected]>
jed326
approved these changes
Mar 19, 2025
navneet1v
approved these changes
Mar 19, 2025
Rajrahane
added a commit
to Rajrahane/remote-vector-index-builder
that referenced
this pull request
Mar 21, 2025
Signed-off-by: Rajvaibhav Rahane <[email protected]> Co-authored-by: Navneet Verma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the faiss submodule and build scripts to create a custom faiss installed base image to be used by the remote-vector-index-build-service-worker.
Issues Resolved
Resolves #4
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.