From c430f147a7f17a76dac27042fc76cdba3226ed39 Mon Sep 17 00:00:00 2001 From: Adam Tackett Date: Thu, 3 Apr 2025 15:40:30 -0700 Subject: [PATCH 1/2] fix flaky app test Signed-off-by: Adam Tackett --- .cypress/integration/app_analytics_test/app_analytics.spec.js | 1 + .cypress/utils/app_constants.js | 1 + 2 files changed, 2 insertions(+) diff --git a/.cypress/integration/app_analytics_test/app_analytics.spec.js b/.cypress/integration/app_analytics_test/app_analytics.spec.js index def0d8826..c825d3328 100644 --- a/.cypress/integration/app_analytics_test/app_analytics.spec.js +++ b/.cypress/integration/app_analytics_test/app_analytics.spec.js @@ -432,6 +432,7 @@ describe('Viewing application', () => { changeTimeTo24('months'); cy.get('[data-test-subj="app-analytics-logTab"]').click(); cy.get('[data-test-subj="superDatePickerApplyTimeButton"]').click(); + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); cy.get('[id="explorerPlotComponent"]', { timeout: timeoutDelay }).should('exist'); cy.get('[data-test-subj="searchAutocompleteTextArea"]').focus(); cy.get('[data-test-subj="searchAutocompleteTextArea"]').type(' ' + query_two, { diff --git a/.cypress/utils/app_constants.js b/.cypress/utils/app_constants.js index 81b11b6c1..ad1521834 100644 --- a/.cypress/utils/app_constants.js +++ b/.cypress/utils/app_constants.js @@ -140,6 +140,7 @@ export const changeTimeTo24 = (timeUnit) => { cy.get('[aria-label="Time unit"]').select(timeUnit); cy.get('.euiButton').contains('Apply').click(); cy.get('[data-test-subj="superDatePickerApplyTimeButton"]').click(); + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); }; export const expectMessageOnHover = (button, message) => { From 3b7570fe8a4d8a5ca6fe73c4e81cf0bbd96b1780 Mon Sep 17 00:00:00 2001 From: Adam Tackett Date: Thu, 3 Apr 2025 16:33:07 -0700 Subject: [PATCH 2/2] fix other flaky test Signed-off-by: Adam Tackett --- .cypress/integration/app_analytics_test/app_analytics.spec.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.cypress/integration/app_analytics_test/app_analytics.spec.js b/.cypress/integration/app_analytics_test/app_analytics.spec.js index c825d3328..4daf73712 100644 --- a/.cypress/integration/app_analytics_test/app_analytics.spec.js +++ b/.cypress/integration/app_analytics_test/app_analytics.spec.js @@ -303,6 +303,7 @@ describe('Viewing application', () => { it('Opens service detail flyout when Service Name is clicked', () => { cy.get('[data-test-subj="app-analytics-serviceTab"]').click(); + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); cy.get('*[data-test-subj^="service-link"]').eq(0).click(); cy.get('[data-test-subj="serviceDetailFlyoutTitle"]').should('be.visible'); cy.get('[data-test-subj="Number of connected servicesDescriptionList"]').should('contain', '3'); @@ -319,6 +320,7 @@ describe('Viewing application', () => { it('Opens trace detail flyout when Trace ID is clicked', () => { cy.get('[data-test-subj="app-analytics-traceTab"]').click(); + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); cy.get('[title="03f9c770db5ee2f1caac0afc36db49ba"]').click(); cy.get('[data-test-subj="traceDetailFlyoutTitle"]').should('be.visible'); cy.get('[data-test-subj="traceDetailFlyout"]').within(($flyout) => { @@ -339,6 +341,7 @@ describe('Viewing application', () => { it('Opens span detail flyout when Span ID is clicked', () => { cy.get('[data-test-subj="app-analytics-traceTab"]').click(); + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); cy.get('input[type="search"]').click().type(`5ff3516909562c60`); cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); cy.get('[data-test-subj="dataGridRowCell"]').contains('5ff3516909562c60').click();