TIA-49: Fixed tab focus styling #36535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubairshakoorarbisoft
force-pushed
the
zubair/fixes
branch
from
cbd1ab0 to
e827853
Compare
…#36094) (openedx#36288) Updates the StudioHome API's allow_to_create_new_org to require both organization-creation permissions and ORGANIZATION_AUTOCREATE to be enabled. It also adds the list of "allowed organizations for libraries" to the Studio Home API so that the Authoring MFE can use it. (cherry picked from commit b96a3bf)
* fix: discussion xblock not compatible with forum v2 (openedx#36315) fix all endpoints that were currently breaking with the discussion xblock. Co-authored-by: Taimoor Ahmed <[email protected]> * fix: legacy discussion issues (openedx#36433) Explicitly passed course_id to all views * fix: legacy forum issues (openedx#36470) Co-authored-by: Taimoor Ahmed <[email protected]> * build: Switch off deprecated C-Hive NPM cache (openedx#36502) JS tests are failing because we are using a discontinued GHA caching service: https://github.blog/changelog/2025-03-20-notification-of-upcoming-breaking-changes-in-github-actions/#decommissioned-cache-service-brownouts This service is used by the unsupported C-Hive caching action which we are relying on: https://github.com/c-hive/gha-npm-cache We are switching to the supported caching mechanims which is provided by setup-node: https://github.com/actions/setup-node?tab=readme-ov-file#caching-global-packages-data * Merge pull request openedx#35713 from openedx/feanil/ubuntu-24.04 feanil/ubuntu 24.04 --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Ali Salman <[email protected]> Co-authored-by: Kyle McCormick <[email protected]> Co-authored-by: Feanil Patel <[email protected]>
zubairshakoorarbisoft
force-pushed
the
zubair/fixes
branch
from
e827853 to
b5b980c
Compare
|
Closing this PR as new and refined PR has been initiated which is including this PR changes here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to overhangio/tutor-indigo#146
On the Teams tab, press left arrow key to bring the focus on “My team” notice that the bottom indicator spreads through all the tabs, and doesn't stay specific to My team's tab
Useful information to include:
After the fix, the focus should move with arrow key without spaning the bottom line on all the tab's bottom, and on pressing Enter key, it should be active.
Supporting information
To have more context on the ticket, please have a look at here(if someone have access)
Testing instructions
One can simply pull the changes on local and build image, the changes should be reflected.
Deadline
N/A
Other information
Include anything else that will help reviewers and consumers understand the change.