Remove the code for nullifying err. Update unit test: return none if both invalid and valid headers exist

Author: tongoss

exporters/otlp/otlplog/otlploggrpc/config_test.go

@@ -81,7 +81,6 @@ func TestNewConfig(t *testing.T) {
 
 	headers := map[string]string{"a": "A"}
 	percentDecodedHeaders := map[string]string{"user%2Did": "42", "user%20name": "alice smith"}
-	validHeaders := map[string]string{"valid-key": "value"}
 	rc := retry.Config{}
 
 	dialOptions := []grpc.DialOption{grpc.WithUserAgent("test-agent")}
@@ -475,7 +474,6 @@ func TestNewConfig(t *testing.T) {
 				endpoint:    newSetting("env.endpoint:8080"),
 				insecure:    newSetting(false),
 				tlsCfg:      newSetting(tlsCfg),
-				headers:     newSetting(validHeaders),
 				compression: newSetting(GzipCompression),
 				timeout:     newSetting(15 * time.Second),
 				retryCfg:    newSetting(defaultRetryCfg),

exporters/otlp/otlplog/otlploghttp/config.go

@@ -563,11 +563,6 @@ func convHeaders(s string) (map[string]string, error) {
 
 		out[key] = val
 	}
-	// If at least one valid header exists, reset err to nil
-	if len(out) > 0 {
-		global.Warn("Some headers were invalid but at least one valid header exists: %v", err)
-		err = nil
-	}
 	return out, err
 }
 

exporters/otlp/otlplog/otlploghttp/config_test.go

@@ -81,7 +81,6 @@ func TestNewConfig(t *testing.T) {
 
 	headers := map[string]string{"a": "A"}
 	percentDecodedHeaders := map[string]string{"user%2Did": "42", "user%20name": "alice smith"}
-	validHeaders := map[string]string{"valid-key": "value"}
 	rc := retry.Config{}
 
 	testcases := []struct {
@@ -407,7 +406,6 @@ func TestNewConfig(t *testing.T) {
 				path:        newSetting("/prefix"),
 				insecure:    newSetting(false),
 				tlsCfg:      newSetting(tlsCfg),
-				headers:     newSetting(validHeaders),
 				compression: newSetting(GzipCompression),
 				timeout:     newSetting(15 * time.Second),
 				retryCfg:    newSetting(defaultRetryCfg),