Provide PolicyViolationContext to Ansible Tower #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into open-cluster-management-io:main from ChunxiAlexLuo:Provide-PolicyViolationContext-to-Ansible-Tower

Oct 31, 2022

Contributor

ChunxiAlexLuo commented Oct 18, 2022 •

edited

Loading

Signed-off-by: Chunxi Luo [email protected]

open-cluster-management-io/enhancements#73

openshift-ci bot added the dco-signoff: yes label

openshift-ci bot requested review from ckandag and gparvin

October 18, 2022 16:20

openshift-ci bot added the approved label

ChunxiAlexLuo requested review from mprahl and willkutler

October 18, 2022 16:32

gparvin reviewed

View reviewed changes

Member

gparvin left a comment

Double check all the fields are checked with the test. Thanks!

test/e2e/case5_policy_automation_test.go Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1/policy_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1/policy_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1/policy_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

api/v1beta1/policyautomation_types.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Outdated Show resolved Hide resolved

openshift-ci bot removed the dco-signoff: yes label

openshift-merge-robot removed the needs-rebase label

ChunxiAlexLuo force-pushed the Provide-PolicyViolationContext-to-Ansible-Tower branch from c4c6ceb to 66247df Compare

October 28, 2022 14:20

openshift-ci bot added dco-signoff: yes and removed dco-signoff: no labels

ChunxiAlexLuo commented

View reviewed changes

controllers/propagator/replication_utils.go Outdated Show resolved Hide resolved

ChunxiAlexLuo requested a review from mprahl

October 28, 2022 14:38

ChunxiAlexLuo force-pushed the Provide-PolicyViolationContext-to-Ansible-Tower branch 2 times, most recently from 9fb12be to 52f1fac Compare

October 28, 2022 15:19

mprahl reviewed

View reviewed changes

controllers/automation/policyautomation_controller.go Show resolved Hide resolved

openshift-merge-robot added the needs-rebase label

ChunxiAlexLuo force-pushed the Provide-PolicyViolationContext-to-Ansible-Tower branch 2 times, most recently from 9442a73 to 30e9e6d Compare

October 28, 2022 19:31

openshift-merge-robot removed the needs-rebase label

openshift-ci bot added dco-signoff: no and removed dco-signoff: yes labels

ChunxiAlexLuo force-pushed the Provide-PolicyViolationContext-to-Ansible-Tower branch from e7b160f to 2d40521 Compare

October 28, 2022 19:32

openshift-ci bot added dco-signoff: yes and removed dco-signoff: no labels


          Provide PolicyViolationContext to Ansible Tower

a25e797

Signed-off-by: Chunxi Luo <[email protected]>

ChunxiAlexLuo force-pushed the Provide-PolicyViolationContext-to-Ansible-Tower branch from 2d40521 to a25e797 Compare

October 28, 2022 19:33

ChunxiAlexLuo requested review from JustinKuli and mprahl

October 28, 2022 21:22

mprahl approved these changes

View reviewed changes

Member

mprahl left a comment

Nice!

openshift-ci bot assigned mprahl

openshift-ci bot added the lgtm label

openshift-ci bot commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChunxiAlexLuo, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ChunxiAlexLuo,mprahl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot merged commit 57955a6 into open-cluster-management-io:main

magic-mirror-bot bot mentioned this pull request

🤖 Sync from open-cluster-management-io/governance-policy-propagator: #52 stolostron/governance-policy-propagator#275

Merged

ChunxiAlexLuo deleted the Provide-PolicyViolationContext-to-Ansible-Tower branch

November 1, 2022 19:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mprahl mprahl approved these changes

ckandag Awaiting requested review from ckandag

willkutler Awaiting requested review from willkutler

gparvin Awaiting requested review from gparvin

JustinKuli Awaiting requested review from JustinKuli

Labels

approved dco-signoff: yes lgtm