Add support for client auth CA from a file #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiraeChristineKim
previously approved these changes
Feb 15, 2024
yiraeChristineKim
previously approved these changes
Feb 15, 2024
| @@ -177,8 +177,8 @@ func getTokenUsername(token string) string { | |||
|
|
|||
| // getCertAuthenticator returns an Authenticator that can validate that an input certificate is signed by the API | |||
| // server represented in the input cfg and that the certificate can be used for client authentication (e.g. key usage). | |||
There was a problem hiding this comment.
Here! in the input cfg comment
This is the default way to set the CA when running in a cluster. Relates: https://issues.redhat.com/browse/ACM-6866 Signed-off-by: mprahl <[email protected]>
yiraeChristineKim
approved these changes
Feb 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default way to set the CA when running in a cluster.
Relates:
https://issues.redhat.com/browse/ACM-6866