From 586c774a80e7838290cd198db4cb98618a17f8b8 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 16:26:47 -0500 Subject: [PATCH 01/14] ci: switch to GitHub Actions --- .github/markdownlint/.markdownlint-cli2.yaml | 16 ++++ .github/workflows/ci.yml | 95 ++++++++++++++++++++ mkdocs.yml | 2 + 3 files changed, 113 insertions(+) create mode 100644 .github/markdownlint/.markdownlint-cli2.yaml create mode 100644 .github/workflows/ci.yml diff --git a/.github/markdownlint/.markdownlint-cli2.yaml b/.github/markdownlint/.markdownlint-cli2.yaml new file mode 100644 index 0000000..3f41881 --- /dev/null +++ b/.github/markdownlint/.markdownlint-cli2.yaml @@ -0,0 +1,16 @@ +# https://github.com/DavidAnson/markdownlint-cli2#markdownlint-cli2yaml + +# additional configuration to the config in the root of the project +# this additional config is used during the markdownlint CI job + +# use custom rule contained in supplementary rules image as a workaround +# more details: https://github.com/DavidAnson/vscode-markdownlint/issues/336 +customRules: + # Enforce one sentence per line + # semantic line breaks (https://sembr.org/) + # See: https://github.com/DavidAnson/markdownlint/pull/719 + - "markdownlint-rule-max-one-sentence-per-line" + +outputFormatters: + - - markdownlint-cli2-formatter-pretty + - - markdownlint-cli2-formatter-sarif diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..4e97f27 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,95 @@ +name: lint + +on: + push: + branches: + - main + pull_request: + workflow_dispatch: + merge_group: + +concurrency: + group: "${{ github.ref }}" + cancel-in-progress: true + + +jobs: + lint: + runs-on: ubuntu-latest + permissions: + # required for upload-sarif action + # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#example-workflow-for-sarif-files-generated-outside-of-a-repository + security-events: write + steps: + - name: Checkout ${{ github.repository }} + uses: actions/checkout@v4.2.2 + - name: Install uv + uses: astral-sh/setup-uv@v5.2.2 + id: setup-uv + with: + # renovate: datasource=pypi dependency=uv + version: "0.5.25" + python-version: 3.13 + - name: Print the installed versions + run: | + echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" + echo "Installed Python version is ${{ steps.setup-uv.outputs.python-version }}" + uv python list + - name: Run pre-commit + uses: pre-commit/action@v3.0.1 + - name: Run markdownlint + uses: YannickTeKulve/docker-run-action@0.0.6 + with: + image: davidanson/markdownlint-cli2-rules:v0.17.2 + # node user does not have permissions to workspace due to user id mismatch + options: -v ${{ github.workspace }}:/workdir --user root + # use the config file that is stored outside the root for CI specific configuration + # don't fail step if there are violations + run: markdownlint-cli2 --config .github/markdownlint/.markdownlint-cli2.yaml "**/*.md" || true + - name: Upload SARIF file + uses: github/codeql-action/upload-sarif@v3 + with: + # Path to SARIF file relative to the root of the repository + sarif_file: markdownlint-cli2-sarif.sarif + # Optional category for the results + # Used to differentiate multiple results for one commit + category: markdownlint + # fail if there are markdownlint violations + - name: Check markdownlint results + run: | + cat markdownlint-cli2-sarif.sarif | grep -q '"results": \[\]' + + + build: + runs-on: ubuntu-latest + needs: + - lint + steps: + - uses: actions/checkout@v4.2.2 + with: + # fetch the full git history to be able to determine creation dates for pages + # see: https://github.com/timvink/mkdocs-git-revision-date-localized-plugin?tab=readme-ov-file#note-when-using-build-environments + fetch-depth: 0 + - name: Install uv + uses: astral-sh/setup-uv@v5.2.2 + id: setup-uv + with: + # renovate: datasource=pypi dependency=uv + version: "0.5.25" + python-version: 3.13 + - name: Print the installed versions + run: | + echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" + echo "Installed Python version is ${{ steps.setup-uv.outputs.python-version }}" + uv python list + - name: Install dependencies + run: uv pip install -r requirements.txt + - run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV + - uses: actions/cache@v4.2.0 + with: + key: mkdocs-material-${{ env.cache_id }} + path: .cache + restore-keys: | + mkdocs-material- + - name: Build site + run: mkdocs build --strict diff --git a/mkdocs.yml b/mkdocs.yml index ce15c55..b2a5d55 100644 --- a/mkdocs.yml +++ b/mkdocs.yml @@ -175,6 +175,8 @@ validation: unrecognized_links: warn anchors: warn +strict: true + watch: - CHANGELOG.md From 9045816c69b549f0166c44d99278d017a68122f1 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 16:30:16 -0500 Subject: [PATCH 02/14] test --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4e97f27..1f696b9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,6 +21,8 @@ jobs: # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#example-workflow-for-sarif-files-generated-outside-of-a-repository security-events: write steps: + - name: foo + run: ls -la - name: Checkout ${{ github.repository }} uses: actions/checkout@v4.2.2 - name: Install uv From 39f89578095440aee0f56ce6fb25faf1ec1e5454 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 21:39:56 -0500 Subject: [PATCH 03/14] add token secret --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1f696b9..718c597 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,10 +21,11 @@ jobs: # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#example-workflow-for-sarif-files-generated-outside-of-a-repository security-events: write steps: - - name: foo - run: ls -la - name: Checkout ${{ github.repository }} uses: actions/checkout@v4.2.2 + with: + token: ${{ secrets.CHECKOUT_TOKEN }} + - name: Install uv uses: astral-sh/setup-uv@v5.2.2 id: setup-uv From 192639c90cbcb1294733a6277124bc9fae8a8db0 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 21:45:59 -0500 Subject: [PATCH 04/14] add permissions to github token instead --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 718c597..e41d2a9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,12 +20,10 @@ jobs: # required for upload-sarif action # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#example-workflow-for-sarif-files-generated-outside-of-a-repository security-events: write + contents: read steps: - name: Checkout ${{ github.repository }} uses: actions/checkout@v4.2.2 - with: - token: ${{ secrets.CHECKOUT_TOKEN }} - - name: Install uv uses: astral-sh/setup-uv@v5.2.2 id: setup-uv From fe47e89ca18be0b83988926019ce87edf2f27b29 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 21:50:54 -0500 Subject: [PATCH 05/14] test --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e41d2a9..cb54827 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,6 +36,8 @@ jobs: echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" echo "Installed Python version is ${{ steps.setup-uv.outputs.python-version }}" uv python list + python --version + python -m pip - name: Run pre-commit uses: pre-commit/action@v3.0.1 - name: Run markdownlint From 28a435f0abf91af2147a1b2380e85c680bd79c6d Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 22:02:33 -0500 Subject: [PATCH 06/14] test --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cb54827..93833ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,7 +30,7 @@ jobs: with: # renovate: datasource=pypi dependency=uv version: "0.5.25" - python-version: 3.13 + python-version: 3.12 - name: Print the installed versions run: | echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" From e9b7e7970f52659c14bd0724a32f6b2eac5f4310 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 22:23:46 -0500 Subject: [PATCH 07/14] use pre-installed Python version --- .github/workflows/ci.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 93833ae..9e21406 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,14 +30,12 @@ jobs: with: # renovate: datasource=pypi dependency=uv version: "0.5.25" - python-version: 3.12 + # ubuntu-latest already has Python 3.x installed (pip is needed by the pre-commit action) - name: Print the installed versions run: | echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" - echo "Installed Python version is ${{ steps.setup-uv.outputs.python-version }}" + echo "Installed Python version is $(python --version)" uv python list - python --version - python -m pip - name: Run pre-commit uses: pre-commit/action@v3.0.1 - name: Run markdownlint From ffcba154cfe46159c9906e09cc2b59ce36972168 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 30 Jan 2025 22:41:05 -0500 Subject: [PATCH 08/14] disable uploading of SARIF file --- .github/workflows/ci.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9e21406..92be223 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,14 +47,16 @@ jobs: # use the config file that is stored outside the root for CI specific configuration # don't fail step if there are violations run: markdownlint-cli2 --config .github/markdownlint/.markdownlint-cli2.yaml "**/*.md" || true - - name: Upload SARIF file - uses: github/codeql-action/upload-sarif@v3 - with: - # Path to SARIF file relative to the root of the repository - sarif_file: markdownlint-cli2-sarif.sarif - # Optional category for the results - # Used to differentiate multiple results for one commit - category: markdownlint + # Needs to be a public repo in order for uploading SARIF files to work + # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github + # - name: Upload SARIF file + # uses: github/codeql-action/upload-sarif@v3 + # with: + # # Path to SARIF file relative to the root of the repository + # sarif_file: markdownlint-cli2-sarif.sarif + # # Optional category for the results + # # Used to differentiate multiple results for one commit + # category: markdownlint # fail if there are markdownlint violations - name: Check markdownlint results run: | From 0a7f3695e9cdc98c1b9a00b20897575a359f11c0 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Fri, 31 Jan 2025 09:31:36 -0500 Subject: [PATCH 09/14] remove GitLab specific stuff --- .github/workflows/ci.yml | 2 +- .gitlab-ci.yml | 75 -------------------- .gitlab/markdownlint/.markdownlint-cli2.yaml | 16 ----- 3 files changed, 1 insertion(+), 92 deletions(-) delete mode 100644 .gitlab-ci.yml delete mode 100644 .gitlab/markdownlint/.markdownlint-cli2.yaml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 92be223..ad466de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,4 +1,4 @@ -name: lint +name: ci on: push: diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml deleted file mode 100644 index 48f4783..0000000 --- a/.gitlab-ci.yml +++ /dev/null @@ -1,75 +0,0 @@ -# Publish docs to GitLab Pages -# see: https://squidfunk.github.io/mkdocs-material/publishing-your-site/#gitlab-pages -# -default: - image: - name: squidfunk/mkdocs-material:9.5.50 - entrypoint: [""] - - -stages: - - lint - - build - - deploy - -pre-commit: - stage: lint - script: - - pip install pre-commit - # skip markdownlint and run it in a separate job since it requires node - - SKIP="markdownlint-cli2" pre-commit run --all - -markdownlint: - stage: lint - image: - name: davidanson/markdownlint-cli2-rules:v0.17.2 - # overwrite default entrypoint (which is a call to markdownlint-cli2) - entrypoint: [""] - script: - # use the config file that is stored outside the root - - markdownlint-cli2 --config .gitlab/markdownlint/.markdownlint-cli2.yaml "**/*.md" - artifacts: - when: always - reports: - codequality: markdownlint-cli2-codequality.json - -build: - stage: build - variables: - # fetch the full git history to be able to determine creation dates for pages - # see: https://github.com/timvink/mkdocs-git-revision-date-localized-plugin?tab=readme-ov-file#note-when-using-build-environments - GIT_DEPTH: 0 - script: - - pip install -r requirements.txt - - mkdocs --version - - mkdocs build --strict --site-dir public - artifacts: - expire_in: 7 days - paths: - - public - -pages: - stage: deploy - rules: - # deploy only on default branch - - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH - script: - - mkdocs --version - artifacts: - paths: - - public - - -workflow: - # auto cancel redundant pipelines - # https://docs.gitlab.com/ee/ci/pipelines/settings.html#auto-cancel-redundant-pipelines - # https://docs.gitlab.com/ee/ci/yaml/index.html#workflowauto_cancelon_new_commit - auto_cancel: - on_new_commit: interruptible - -include: - # run pipelines for default branch, tags, and all types of merge request pipelines - # to support merge trains - # see: https://docs.gitlab.com/ee/ci/pipelines/merge_trains.html#enable-merge-trains - # https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/ci/templates/Workflows/MergeRequest-Pipelines.gitlab-ci.yml - - template: Workflows/MergeRequest-Pipelines.gitlab-ci.yml diff --git a/.gitlab/markdownlint/.markdownlint-cli2.yaml b/.gitlab/markdownlint/.markdownlint-cli2.yaml deleted file mode 100644 index 2320768..0000000 --- a/.gitlab/markdownlint/.markdownlint-cli2.yaml +++ /dev/null @@ -1,16 +0,0 @@ -# https://github.com/DavidAnson/markdownlint-cli2#markdownlint-cli2yaml - -# additional configuration to the config in the root of the project -# this additional config is used during the markdownlint CI job - -# use custom rule contained in supplementary rules image as a workaround -# more details: https://github.com/DavidAnson/vscode-markdownlint/issues/336 -customRules: - # Enforce one sentence per line - # semantic line breaks (https://sembr.org/) - # See: https://github.com/DavidAnson/markdownlint/pull/719 - - "markdownlint-rule-max-one-sentence-per-line" - -outputFormatters: - - - markdownlint-cli2-formatter-default - - - markdownlint-cli2-formatter-codequality From c5cd5f6d3e06c0ef97bd0540da91ff4a168e97a3 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Fri, 31 Jan 2025 15:05:02 -0500 Subject: [PATCH 10/14] add deploy workflow --- .github/workflows/ci.yml | 21 +++++-------- .github/workflows/deploy.yml | 59 ++++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+), 13 deletions(-) create mode 100644 .github/workflows/deploy.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ad466de..d2686d1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,10 +22,8 @@ jobs: security-events: write contents: read steps: - - name: Checkout ${{ github.repository }} - uses: actions/checkout@v4.2.2 - - name: Install uv - uses: astral-sh/setup-uv@v5.2.2 + - uses: actions/checkout@v4.2.2 + - uses: astral-sh/setup-uv@v5.2.2 id: setup-uv with: # renovate: datasource=pypi dependency=uv @@ -36,8 +34,7 @@ jobs: echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" echo "Installed Python version is $(python --version)" uv python list - - name: Run pre-commit - uses: pre-commit/action@v3.0.1 + - uses: pre-commit/action@v3.0.1 - name: Run markdownlint uses: YannickTeKulve/docker-run-action@0.0.6 with: @@ -49,8 +46,7 @@ jobs: run: markdownlint-cli2 --config .github/markdownlint/.markdownlint-cli2.yaml "**/*.md" || true # Needs to be a public repo in order for uploading SARIF files to work # https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github - # - name: Upload SARIF file - # uses: github/codeql-action/upload-sarif@v3 + # - uses: github/codeql-action/upload-sarif@v3 # with: # # Path to SARIF file relative to the root of the repository # sarif_file: markdownlint-cli2-sarif.sarif @@ -73,8 +69,7 @@ jobs: # fetch the full git history to be able to determine creation dates for pages # see: https://github.com/timvink/mkdocs-git-revision-date-localized-plugin?tab=readme-ov-file#note-when-using-build-environments fetch-depth: 0 - - name: Install uv - uses: astral-sh/setup-uv@v5.2.2 + - uses: astral-sh/setup-uv@v5.2.2 id: setup-uv with: # renovate: datasource=pypi dependency=uv @@ -83,14 +78,14 @@ jobs: - name: Print the installed versions run: | echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" - echo "Installed Python version is ${{ steps.setup-uv.outputs.python-version }}" + echo "Installed Python version is $(python --version)" uv python list - name: Install dependencies run: uv pip install -r requirements.txt - - run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV - uses: actions/cache@v4.2.0 with: - key: mkdocs-material-${{ env.cache_id }} + # weekly cache + key: mkdocs-material-$(date --utc '+%V') path: .cache restore-keys: | mkdocs-material- diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml new file mode 100644 index 0000000..171c173 --- /dev/null +++ b/.github/workflows/deploy.yml @@ -0,0 +1,59 @@ +name: deploy + +on: + workflow_run: + workflows: [ci] + # branches: + # - main + types: + - completed + workflow_dispatch: + +concurrency: + group: "${{ github.ref }}" + cancel-in-progress: true + +jobs: + lint: + runs-on: ubuntu-latest + # only run if CI workflow completed successfully + # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow + if: ${{ github.event.workflow_run.conclusion == 'success' }} + permissions: + contents: read + environment: pages + steps: + - uses: actions/checkout@v4.2.2 + with: + # fetch the full git history to be able to determine creation dates for pages + # see: https://github.com/timvink/mkdocs-git-revision-date-localized-plugin?tab=readme-ov-file#note-when-using-build-environments + fetch-depth: 0 + - name: Configure Git Credentials + # see: https://github.com/actions/checkout#push-a-commit-using-the-built-in-token + run: | + git config user.name github-actions[bot] + git config user.email 41898282+github-actions[bot]@users.noreply.github.com + - name: Install uv + uses: astral-sh/setup-uv@v5.2.2 + id: setup-uv + with: + # renovate: datasource=pypi dependency=uv + version: "0.5.25" + python-version: 3.13 + - name: Print the installed versions + run: | + echo "Installed uv version is ${{ steps.setup-uv.outputs.uv-version }}" + echo "Installed Python version is $(python --version)" + uv python list + - name: Install dependencies + run: uv pip install -r requirements.txt + - run: echo "cache_id=$(date --utc '+%V')" >> $GITHUB_ENV + - uses: actions/cache@v4.2.0 + with: + key: mkdocs-material-${{ env.cache_id }} + path: .cache + restore-keys: | + mkdocs-material- + - name: Deploy to GitHub Pages + # see: https://squidfunk.github.io/mkdocs-material/publishing-your-site/#with-github-actions + run: mkdocs gh-deploy --strict --force From fc8511c7a80aeda147a840dce7159e81d043e452 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Fri, 31 Jan 2025 21:44:58 -0500 Subject: [PATCH 11/14] temporarily enable PR deploy --- .github/workflows/deploy.yml | 5 +++-- README.md | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 171c173..c1c0976 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -3,11 +3,12 @@ name: deploy on: workflow_run: workflows: [ci] - # branches: - # - main + branches: + - main types: - completed workflow_dispatch: + pull_request: concurrency: group: "${{ github.ref }}" diff --git a/README.md b/README.md index 80feb50..65d83d5 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Opal Documentation -[![pipeline status](https://gitlab.com/opalmedapps/docs/badges/main/pipeline.svg)](https://gitlab.com/opalmedapps/docs/-/commits/main) [![Docs](https://img.shields.io/badge/docs-available-brightgreen.svg)](https://docs.opalmedapps.ca) +[![ci](https://github.com/opalmedapps/docs/actions/workflows/ci.yml/badge.svg)](https://github.com/opalmedapps/docs/actions/workflows/ci.yml) [![Docs](https://img.shields.io/badge/docs-available-brightgreen.svg)](https://docs.opalmedapps.com) Project for the Opal documentation site. @@ -9,7 +9,7 @@ Material for MkDocs makes use of [Python Markdown](https://python-markdown.githu In addition, we use the [PlantUML Markdown extension](https://github.com/mikitex70/plantuml-markdown) to render [PlantUML](https://plantuml.com) diagrams. -The documentation site is deployed to GitLab Pages at https://docs.opalmedapps.ca. +The documentation site is deployed to GitHub Pages at https://docs.opalmedapps.com. ## Contributing From d14f93725a8d0757d195dfa80c80907c49540209 Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Fri, 31 Jan 2025 22:33:23 -0500 Subject: [PATCH 12/14] fix deploy job --- .github/workflows/deploy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index c1c0976..644cf0f 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -15,11 +15,11 @@ concurrency: cancel-in-progress: true jobs: - lint: + deploy: runs-on: ubuntu-latest # only run if CI workflow completed successfully # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow - if: ${{ github.event.workflow_run.conclusion == 'success' }} + # if: ${{ github.event.workflow_run.conclusion == 'success' }} permissions: contents: read environment: pages From 9476646b8044f8ecd93fcab6d2a599de7c84f99c Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Fri, 31 Jan 2025 22:41:21 -0500 Subject: [PATCH 13/14] add write permission --- .github/workflows/deploy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 644cf0f..e034985 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -11,7 +11,7 @@ on: pull_request: concurrency: - group: "${{ github.ref }}" + group: deploy cancel-in-progress: true jobs: @@ -21,7 +21,7 @@ jobs: # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow # if: ${{ github.event.workflow_run.conclusion == 'success' }} permissions: - contents: read + contents: write environment: pages steps: - uses: actions/checkout@v4.2.2 From bb49a15969525408a053ad7e78512e314a3ff69f Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Mon, 3 Feb 2025 15:06:47 -0500 Subject: [PATCH 14/14] revert --- .github/workflows/deploy.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index e034985..111ec0d 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -8,7 +8,6 @@ on: types: - completed workflow_dispatch: - pull_request: concurrency: group: deploy @@ -19,7 +18,7 @@ jobs: runs-on: ubuntu-latest # only run if CI workflow completed successfully # https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow - # if: ${{ github.event.workflow_run.conclusion == 'success' }} + if: ${{ github.event.workflow_run.conclusion == 'success' }} permissions: contents: write environment: pages