Skip to content

fix(powershell): multiple Invoke-Expression fixes #8318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2025

Conversation

alexsch01
Copy link
Contributor

  • prevent pipeline input from using Invoke-Expression
  • allow redirect operator to behave again by stripping redirects out from Invoke-Expression

@alexsch01 alexsch01 requested a review from a team as a code owner May 22, 2025 13:17
Copy link
Contributor

@mbtools mbtools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes the Windows Shim Tests. LGTM 👍

@alexsch01
Copy link
Contributor Author

@wraithgar it's ready!

@wraithgar wraithgar merged commit e758dd7 into npm:latest May 27, 2025
20 checks passed
@github-actions github-actions bot mentioned this pull request May 27, 2025
alexsch01 added a commit to alexsch01/cli that referenced this pull request Jun 3, 2025
- prevent pipeline input from using Invoke-Expression
- allow redirect operator to behave again by stripping redirects out
from Invoke-Expression
@wraithgar
Copy link
Member

The v10 branch just had its dependencies updated, and we are likely going to want to roll out a backport release for v10. It would be nice to have the sum of the .ps1 changes added to v10 also. Is this something you would be willing to do @alexsch01 or @mbtools? If so you can branch and PR off of release/v10.

If you'd prefer you can give me an idea of what files to bring over and I can make the PR.

@alexsch01
Copy link
Contributor Author

@wraithgar #8343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants