From fe0fd9f7bfdd9cc80d574a5b24393534640ae25f Mon Sep 17 00:00:00 2001 From: Gabriel Fournier Date: Thu, 17 Dec 2020 18:18:40 -0500 Subject: [PATCH 1/2] fix: Reexport SamlConfig type to solve a regression in consumer packages --- src/passport-saml/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/passport-saml/index.ts b/src/passport-saml/index.ts index 3b21daad..976ce744 100644 --- a/src/passport-saml/index.ts +++ b/src/passport-saml/index.ts @@ -2,6 +2,6 @@ import type { CacheItem, CacheProvider} from './inmemory-cache-provider'; import { SAML } from './saml'; import Strategy = require('./strategy'); import MultiSamlStrategy = require('./multiSamlStrategy'); -import type { Profile, VerifiedCallback, VerifyWithRequest, VerifyWithoutRequest } from './types'; +import type { Profile, SamlConfig, VerifiedCallback, VerifyWithRequest, VerifyWithoutRequest } from './types'; -export { SAML, Strategy, MultiSamlStrategy, CacheItem, CacheProvider, Profile, VerifiedCallback, VerifyWithRequest, VerifyWithoutRequest }; +export { SAML, Strategy, MultiSamlStrategy, CacheItem, CacheProvider, Profile, SamlConfig, VerifiedCallback, VerifyWithRequest, VerifyWithoutRequest }; From e30fbee84d157981df45b51eee5cc2e53a5dadfd Mon Sep 17 00:00:00 2001 From: Gabriel Fournier Date: Thu, 17 Dec 2020 18:20:59 -0500 Subject: [PATCH 2/2] doc: Typo in template --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a493212b..09c4055f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,6 @@ # Description -Thank you for taking the time to create a PR to support this commuity-maintained project. We are all volunteers here, so features are only added by contributers like you. Please also be patient while the maintainers work to review your proposed changes for quality and effacy. +Thank you for taking the time to create a PR to support this community-maintained project. We are all volunteers here, so features are only added by contributers like you. Please also be patient while the maintainers work to review your proposed changes for quality and effacy. Please include a _summary of the change_ and, where appropriate, _which issue is addressed_.