From 309aa128bbe4fae33aedc7230ee723257df5b43a Mon Sep 17 00:00:00 2001 From: gichan2-jang Date: Tue, 2 Jul 2024 17:09:06 +0900 Subject: [PATCH 1/2] [Actions] Add spell checker Add spell checker github action Signed-off-by: gichan2-jang --- .github/workflows/_typos.toml | 4 ++++ .github/workflows/spell-checker.yml | 17 +++++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 .github/workflows/_typos.toml create mode 100644 .github/workflows/spell-checker.yml diff --git a/.github/workflows/_typos.toml b/.github/workflows/_typos.toml new file mode 100644 index 0000000..4cbdbc8 --- /dev/null +++ b/.github/workflows/_typos.toml @@ -0,0 +1,4 @@ +[files] +extend-exclude = [] + +[default.extend-words] diff --git a/.github/workflows/spell-checker.yml b/.github/workflows/spell-checker.yml new file mode 100644 index 0000000..ffa0b91 --- /dev/null +++ b/.github/workflows/spell-checker.yml @@ -0,0 +1,17 @@ +name: Spell Check + +on: + pull_request: + branches: [ main ] + +jobs: + typos-check: + name: Spell Check with Typos + runs-on: ubuntu-latest + steps: + - name: Checkout Actions Repository + uses: actions/checkout@v4 + - name: Check spelling + uses: crate-ci/typos@master + with: + config: ./.github/workflows/_typos.toml From 6318877a54f1296de93fcf1934fdb0a5aae49dd0 Mon Sep 17 00:00:00 2001 From: gichan2-jang Date: Tue, 2 Jul 2024 17:15:35 +0900 Subject: [PATCH 2/2] Fix typos Fix typos detected by spell checker Signed-off-by: gichan2-jang --- daemon/pipeline-dbus-impl.cc | 6 ++--- packaging/mlops-agent.spec | 2 +- tests/daemon/unittest_service_db.cc | 26 +++++++++---------- .../unittest_mlops_plugin_parser.cc | 2 +- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/daemon/pipeline-dbus-impl.cc b/daemon/pipeline-dbus-impl.cc index e87a3c9..07642ec 100644 --- a/daemon/pipeline-dbus-impl.cc +++ b/daemon/pipeline-dbus-impl.cc @@ -220,7 +220,7 @@ dbus_cb_core_start_pipeline (MachinelearningServicePipeline *obj, g_mutex_unlock (&p->lock); if (sc_ret == GST_STATE_CHANGE_FAILURE) { - ml_loge ("Failed to set the state of the pipline to PLAYING whose service name is %s.", + ml_loge ("Failed to set the state of the pipeline to PLAYING whose service name is %s.", p->service_name); result = -ESTRPIPE; } @@ -256,7 +256,7 @@ dbus_cb_core_stop_pipeline (MachinelearningServicePipeline *obj, g_mutex_unlock (&p->lock); if (sc_ret == GST_STATE_CHANGE_FAILURE) { - ml_loge ("Failed to set the state of the pipline to PAUSED whose service name is %s.", + ml_loge ("Failed to set the state of the pipeline to PAUSED whose service name is %s.", p->service_name); result = -ESTRPIPE; } @@ -337,7 +337,7 @@ dbus_cb_core_get_state (MachinelearningServicePipeline *obj, g_mutex_unlock (&p->lock); if (sc_ret == GST_STATE_CHANGE_FAILURE) { - ml_loge ("Failed to get the state of the pipline whose service name is %s.", + ml_loge ("Failed to get the state of the pipeline whose service name is %s.", p->service_name); result = -ESTRPIPE; } diff --git a/packaging/mlops-agent.spec b/packaging/mlops-agent.spec index 75d5e56..aef3c95 100644 --- a/packaging/mlops-agent.spec +++ b/packaging/mlops-agent.spec @@ -32,7 +32,7 @@ %define enable_test -Denable-test=false %define install_test -Dinstall-test=false -# To generage gcov package, --define "gcov 1" +# To generate gcov package, --define "gcov 1" %if 0%{?gcov:1} %define unit_test 1 %define release_test 1 diff --git a/tests/daemon/unittest_service_db.cc b/tests/daemon/unittest_service_db.cc index 4575f81..057c83e 100644 --- a/tests/daemon/unittest_service_db.cc +++ b/tests/daemon/unittest_service_db.cc @@ -345,9 +345,9 @@ TEST (serviceDB, delete_model_activated_n) } /** - * @brief Negative test for set_pipline. DB is not initialized. + * @brief Negative test for set_pipeline. DB is not initialized. */ -TEST (serviceDBNotInitalized, set_pipeline_n) +TEST (serviceDBNotInitialized, set_pipeline_n) { MLServiceDB db (TEST_DB_PATH); @@ -360,9 +360,9 @@ TEST (serviceDBNotInitalized, set_pipeline_n) } /** - * @brief Negative test for get_pipline. DB is not initialized. + * @brief Negative test for get_pipeline. DB is not initialized. */ -TEST (serviceDBNotInitalized, get_pipeline_n) +TEST (serviceDBNotInitialized, get_pipeline_n) { MLServiceDB db (TEST_DB_PATH); @@ -378,7 +378,7 @@ TEST (serviceDBNotInitalized, get_pipeline_n) /** * @brief Negative test for delete_pipeline. DB is not initialized. */ -TEST (serviceDBNotInitalized, delete_pipeline_n) +TEST (serviceDBNotInitialized, delete_pipeline_n) { MLServiceDB db (TEST_DB_PATH); @@ -393,7 +393,7 @@ TEST (serviceDBNotInitalized, delete_pipeline_n) /** * @brief Negative test for set_model. DB is not initialized. */ -TEST (serviceDBNotInitalized, set_model_n) +TEST (serviceDBNotInitialized, set_model_n) { MLServiceDB db (TEST_DB_PATH); @@ -409,7 +409,7 @@ TEST (serviceDBNotInitalized, set_model_n) /** * @brief Negative test for update_model_description. DB is not initialized. */ -TEST (serviceDBNotInitalized, update_model_description_n) +TEST (serviceDBNotInitialized, update_model_description_n) { MLServiceDB db (TEST_DB_PATH); @@ -424,7 +424,7 @@ TEST (serviceDBNotInitalized, update_model_description_n) /** * @brief Negative test for activate_model. DB is not initialized. */ -TEST (serviceDBNotInitalized, activate_model_n) +TEST (serviceDBNotInitialized, activate_model_n) { MLServiceDB db (TEST_DB_PATH); @@ -439,7 +439,7 @@ TEST (serviceDBNotInitalized, activate_model_n) /** * @brief Negative test for get_model. DB is not initialized. */ -TEST (serviceDBNotInitalized, get_model_n) +TEST (serviceDBNotInitialized, get_model_n) { MLServiceDB db (TEST_DB_PATH); @@ -455,7 +455,7 @@ TEST (serviceDBNotInitalized, get_model_n) /** * @brief Negative test for delete_model. DB is not initialized. */ -TEST (serviceDBNotInitalized, delete_model_n) +TEST (serviceDBNotInitialized, delete_model_n) { MLServiceDB db (TEST_DB_PATH); @@ -632,7 +632,7 @@ TEST (serviceDB, delete_resource_unregistered_n) /** * @brief Negative test for set_resource. DB is not initialized. */ -TEST (serviceDBNotInitalized, set_resource_n) +TEST (serviceDBNotInitialized, set_resource_n) { MLServiceDB db (TEST_DB_PATH); @@ -647,7 +647,7 @@ TEST (serviceDBNotInitalized, set_resource_n) /** * @brief Negative test for get_resource. DB is not initialized. */ -TEST (serviceDBNotInitalized, get_resource_n) +TEST (serviceDBNotInitialized, get_resource_n) { MLServiceDB db (TEST_DB_PATH); @@ -663,7 +663,7 @@ TEST (serviceDBNotInitalized, get_resource_n) /** * @brief Negative test for delete_resource. DB is not initialized. */ -TEST (serviceDBNotInitalized, delete_resource_n) +TEST (serviceDBNotInitialized, delete_resource_n) { MLServiceDB db (TEST_DB_PATH); diff --git a/tests/plugin-parser/unittest_mlops_plugin_parser.cc b/tests/plugin-parser/unittest_mlops_plugin_parser.cc index f4386f9..da73f32 100644 --- a/tests/plugin-parser/unittest_mlops_plugin_parser.cc +++ b/tests/plugin-parser/unittest_mlops_plugin_parser.cc @@ -116,7 +116,7 @@ pkgmgrinfo_pkginfo_get_res_version (pkgmgrinfo_pkginfo_h handle, char **return_r } /** - * @brief pluging-parser test fixture + * @brief plugin-parser test fixture */ class PkgMgrInfoMockTestFixture : public ::testing::Test {