Remove baseUrl and skipLibCheck #45806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45806--material-ui.netlify.app/ Bundle size report |
JCQuintas
reviewed
Apr 3, 2025
| - apps/* | ||
| - scripts/sizeSnapshot | ||
| patchedDependencies: | ||
| styled-components: patches/styled-components.patch |
There was a problem hiding this comment.
Was this patch meant to be added? 🤔
There was a problem hiding this comment.
yes, it's meant to replace skipLibCheck. It would be equally broken on end-users side (if they have deprecated styled-components installed), but at least we're not sweeping other errors under the rug.
JCQuintas
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to be able to resolve from the monorepo root everywhere in the project. Ideally these paths are defined on the package level, and mimic the workspace dependencies of that specific package only.
Also removing skipLibCheck in @mui/system