Skip to content

Fix config for new MSVC preprocessor #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix config for new MSVC preprocessor #1040

merged 1 commit into from
Nov 9, 2022

Conversation

laitingsheng
Copy link

The new MSVC preprocessor is now standard-conformant. It should use the standard (strict) macro definition if /Zc:preprocessor is specified.

@codecov-commenter
Copy link

Codecov Report

Merging #1040 (8fac2a5) into cpp_master (7e56a08) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           cpp_master    #1040   +/-   ##
===========================================
  Coverage       85.60%   85.60%           
===========================================
  Files              79       79           
  Lines            5023     5023           
===========================================
  Hits             4300     4300           
  Misses            723      723           

@redboltz
Copy link
Contributor

redboltz commented Nov 9, 2022

LGTM thanks!

@redboltz redboltz merged commit 7c3ef8e into msgpack:cpp_master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants