Skip to content

TSL: Fix inconsistent chaining for .step() (Parameter order) #31241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 8, 2025

Closes #31205

Description

Fix inconsistent chaining for .step(). #31205 (comment)

@sunag sunag added this to the r178 milestone Jun 8, 2025
@sunag sunag changed the title TSL: Fix inconsistent chaining for .step() TSL: Fix inconsistent chaining for .step() (Parameter order) Jun 8, 2025
Copy link

github-actions bot commented Jun 8, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.4
78.67
337.4
78.67
+0 B
+0 B
WebGPU 554.99
153.61
555.02
153.63
+33 B
+23 B
WebGPU Nodes 554.34
153.46
554.38
153.48
+33 B
+22 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.59
113.33
468.59
113.33
+0 B
+0 B
WebGPU 630.02
170.38
630.03
170.39
+14 B
+3 B
WebGPU Nodes 584.87
159.73
584.88
159.73
+14 B
+3 B

@sunag sunag marked this pull request as ready for review June 8, 2025 08:21
@sunag sunag merged commit 8faa068 into mrdoob:dev Jun 10, 2025
12 checks passed
@sunag sunag deleted the dev-fix-step branch June 10, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSL: Inconsistent chaining for step vs smoothstep
1 participant