Use positive dimensions for text chunks in the text layer (issue #14415)

[calixteman]

Width/height for text chunks must be positive numbers.

[calixteman]

Just adding Math.abs on dims was not enough: no space were added between "This" and "agreement" because of the orientation (rotation == 180 and font size is negative).

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/63b86dd125117e4/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9b12f6f8efe8746/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/63b86dd125117e4/output.txt

Total script time: 22.50 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 13
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/63b86dd125117e4/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/9b12f6f8efe8746/output.txt

Total script time: 42.42 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/9b12f6f8efe8746/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

There seem to be some regressions in taro-text-page3 (and taro-text-enhance-page3), for all platforms and browsers.

[calixteman]

This is because of:
https://github.com/mozilla/pdf.js/pull/14418/files#diff-cf40014d9c7d352f3ae212e7fffe5386decf96a10e53066a4d900c3eb8fc559eR2479
I changed it because it's inconsistent with:

pdf.js/src/core/evaluator.js

Line 2475 in 568633c

if (Math.abs(advanceX) > textContentItem.height) {

So for example, if you look on the fifth column on page 3:

before my patch we've a white, a break and a chunk with Japanese glyphes, and after my patch we've a chunk with a white and Japanese glyphes, the position of the span changed because the first char in the span is not the same.

Anyway, this change isn't directly related to what this patch is aimed to fix (I just noticed the error in reading the code and I thought that it doesn't hurt to fix a "typo").
So I'll remove it and I'll fix the issue in an other patch.

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2d1863414a69a34/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/eeba09b2d2e4d35/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/2d1863414a69a34/output.txt

Total script time: 22.49 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/2d1863414a69a34/reftest-analyzer.html#web=eq.log

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/eeba09b2d2e4d35/output.txt

Total script time: 42.46 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 7
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/eeba09b2d2e4d35/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/634a43db92b4c08/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/634a43db92b4c08/output.txt

Total script time: 4.45 mins

Published

• Viewer: http://54.241.84.105:8877/634a43db92b4c08/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/634a43db92b4c08/legacy/web/viewer.html

[Snuffleupagus]

/botio makeref

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/626a43116c9737c/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/ac6ee723dcf9a81/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/626a43116c9737c/output.txt

Total script time: 19.99 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/ac6ee723dcf9a81/output.txt

Total script time: 38.78 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed