Skip to content

Handle errors correctly when data lookup fails during /Pages-tree parsing (issue 14303) #14333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Dec 1, 2021

This only applies to severely corrupt documents, where it's possible that the Parser throws when we try to access e.g. a /Kids-entry in the /Pages-tree.

Fixes two of the issues listed in issue #14303, namely the poppler-742-0.pdf... and poppler-937-0.pdf... documents.

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/73e576316f49487/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d71a2cb815fe3c7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/73e576316f49487/output.txt

Total script time: 21.52 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/73e576316f49487/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Dec 1, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d71a2cb815fe3c7/output.txt

Total script time: 41.94 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/d71a2cb815fe3c7/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

The commit message was updated slightly, however no actual code changes were made.

…sing (issue 14303)

This only applies to severely corrupt documents, where it's possible that the `Parser` throws when we try to access e.g. a /Kids-entry in the /Pages-tree.

Fixes two of the issues listed in issue 14303, namely the `poppler-742-0.pdf...` and `poppler-937-0.pdf...` documents.
@pdfjsbot
Copy link

pdfjsbot commented Dec 2, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ed96e52e77838e0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 2, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/caf360b582f9aba/output.txt

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdfjsbot
Copy link

pdfjsbot commented Dec 2, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ed96e52e77838e0/output.txt

Total script time: 21.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/ed96e52e77838e0/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Dec 2, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/caf360b582f9aba/output.txt

Total script time: 42.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/caf360b582f9aba/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit d9e0de8 into mozilla:master Dec 2, 2021
@Snuffleupagus Snuffleupagus deleted the Pages-tree-corruption branch December 2, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants