-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Handle errors correctly when data lookup fails during /Pages-tree parsing (issue 14303) #14333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors correctly when data lookup fails during /Pages-tree parsing (issue 14303) #14333
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/73e576316f49487/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d71a2cb815fe3c7/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/73e576316f49487/output.txt Total script time: 21.52 mins
Image differences available at: http://54.241.84.105:8877/73e576316f49487/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d71a2cb815fe3c7/output.txt Total script time: 41.94 mins
Image differences available at: http://54.193.163.58:8877/d71a2cb815fe3c7/reftest-analyzer.html#web=eq.log |
5a02ff2
to
3a740de
Compare
The commit message was updated slightly, however no actual code changes were made. |
…sing (issue 14303) This only applies to severely corrupt documents, where it's possible that the `Parser` throws when we try to access e.g. a /Kids-entry in the /Pages-tree. Fixes two of the issues listed in issue 14303, namely the `poppler-742-0.pdf...` and `poppler-937-0.pdf...` documents.
3a740de
to
63be23f
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ed96e52e77838e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/caf360b582f9aba/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ed96e52e77838e0/output.txt Total script time: 21.66 mins
Image differences available at: http://54.241.84.105:8877/ed96e52e77838e0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/caf360b582f9aba/output.txt Total script time: 42.05 mins
Image differences available at: http://54.193.163.58:8877/caf360b582f9aba/reftest-analyzer.html#web=eq.log |
This only applies to severely corrupt documents, where it's possible that the
Parser
throws when we try to access e.g. a /Kids-entry in the /Pages-tree.Fixes two of the issues listed in issue #14303, namely the
poppler-742-0.pdf...
andpoppler-937-0.pdf...
documents.