Make verifyManifestFiles fail for non-linked test-cases with a "link": true-entry
#13996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nk": true`-entry Currently it's possible to accidentally, e.g. by simply copy-and-pasting from an existing test-case, add an unnecessary `"link": true`-entry for locally available PDF files. This leads to inconsistencies in the manifest file, and doesn't feel like a great developer experience. However we can easily fix it by having `verifyManifestFiles` fail in this situation, and doing so actually turned up a couple of existing cases.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ab627edd7622333/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/32b8116aefe525e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ab627edd7622333/output.txt Total script time: 2.88 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/32b8116aefe525e/output.txt Total script time: 5.88 mins
|
calixteman
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible to accidentally, e.g. by simply copy-and-pasting from an existing test-case, add an unnecessary
"link": true-entry for locally available PDF files.This leads to inconsistencies in the manifest file, and doesn't feel like a great developer experience. However we can easily fix it by having
verifyManifestFilesfail in this situation, and doing so actually turned up a couple of existing cases.