Correctly pad strings when saving an encrypted pdf (bug 1726789)

[calixteman]

No description provided.

[calixteman]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/72618ade8d68d34/output.txt

[timvandermeij]

Would it be possible to add a unit test for this since this is core functionality? This particular function can be called with the input that failed before and there is even a helper function that asserts that it can also be decoded again:

pdf.js/test/unit/crypto_spec.js

Lines 584 to 591 in 7d9a830

	function ensureEncryptDecryptIsIdentity(dict, fileId, password, string) {
	const factory = new CipherTransformFactory(dict, fileId, password);
	const cipher = factory.createCipherTransform(123, 0);
	const encrypted = cipher.encryptString(string);
	const decrypted = cipher.decryptString(encrypted);
	expect(string).toEqual(decrypted);
	}

Something like this make work here since the code path in this PR is limited to AES:

pdf.js/test/unit/crypto_spec.js

Lines 824 to 845 in 0a366dd

	it("should encrypt and decrypt using AES256", function () {
	dict3.CF = buildDict({
	Identity: buildDict({
	CFM: Name.get("AESV3"),
	}),
	});
	const dict = buildDict(dict3);
	// 4 chars
	ensureEncryptDecryptIsIdentity(dict, fileId1, "user", "aaaa");
	// 5 chars
	ensureEncryptDecryptIsIdentity(dict, fileId1, "user", "aaaaa");
	// 16 chars
	ensureEncryptDecryptIsIdentity(dict, fileId1, "user", "aaaaaaaaaaaaaaaa");
	// 22 chars
	ensureEncryptDecryptIsIdentity(
	dict,
	fileId1,
	"user",
	"aaaaaaaaaaaaaaaaaaaaaa"
	);
	});
	});

[calixteman]

Before the patch, pdf.js, evince, mupdf and qpdf were able to decrypt correctly the string but not foxit, chrome and acrobat.
There is already a test with a string where length is a multiple of 16 (e.g. https://github.com/mozilla/pdf.js/blob/master/test/unit/crypto_spec.js#L836).
So I don't see how to have a test which fails without the patch, any idea will be appreciated.

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://3.101.106.178:8877/72618ade8d68d34/output.txt

Total script time: 39.76 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: Passed
• Regression tests: FAILED

  different ref/snapshot: 28
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/72618ade8d68d34/reftest-analyzer.html#web=eq.log

[calixteman]

/botio unittest

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/7bcb7f6b44dd480/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6b12066d178e9eb/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/6b12066d178e9eb/output.txt

Total script time: 2.74 mins

• Unit Tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://3.101.106.178:8877/7bcb7f6b44dd480/output.txt

Total script time: 5.43 mins

• Unit Tests: Passed