A couple of small TextHighlighter/TextLayerBuilder tweaks (PR 13908 follow-up)
#13935
Conversation
…08 follow-up) - Use `Node.TEXT_NODE` rather than a magical constant, in `TextHighlighter._convertMatches`, to improve readability. According to MDN, this has been supported since "forever": https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeType#browser_compatibility - Remove the `pageIdx`-property, on `TextLayerBuilder`-instances, since the re-factoring in PR 13908 meant that it's now unused. - Remove the `matches`-property, on `TextLayerBuilder`-instances, since the re-factoring in PR 13908 meant that it's now unused.
Snuffleupagus
force-pushed
the
TextHighlighter-tweaks
branch
from
f429bf2 to
fa4e82c
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f7df2a5e0f3bdf4/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/22f651872e74034/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/22f651872e74034/output.txt Total script time: 4.56 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/f7df2a5e0f3bdf4/output.txt Total script time: 5.62 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/543b8190ed09559/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/02263d4fb520c56/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/543b8190ed09559/output.txt Total script time: 4.39 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/02263d4fb520c56/output.txt Total script time: 5.77 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/afa36997498d76b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/afa36997498d76b/output.txt Total script time: 5.23 mins Published |
|
Thank you for cleaning this up! |
Use
Node.TEXT_NODErather than a magical constant, inTextHighlighter._convertMatches, to improve readability. According to MDN, this has been supported since "forever": https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeType#browser_compatibilityRemove the
pageIdx-property, onTextLayerBuilder-instances, since the re-factoring in PR [api-minor] XFA - Support text search in XFA documents. #13908 meant that it's now unused.Remove the
matches-property, onTextLayerBuilder-instances, since the re-factoring in PR [api-minor] XFA - Support text search in XFA documents. #13908 meant that it's now unused.