Remove a couple of closures in the src/display/api.js file
#13813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
rm-closure-API
branch
from
8d3ccc3 to
99c48df
Compare
This patch utilizes the same approach as used in lots of other parts of the code-base, which thus *slightly* reduces the size of this code. By removing some of the (current) indirection, we can also simplify the JSDocs a little bit. Looking at the `gulp jsdoc` output, this actually seem to *improve* the documentation for this class.
This patch utilizes the same approach as used in lots of other parts of the code-base, which thus *slightly* reduces the size of this code.
…orkerMessageHandler`
Snuffleupagus
force-pushed
the
rm-closure-API
branch
from
99c48df to
5fac0a4
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d7a406e0711f6ae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/997b4d069de1994/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d7a406e0711f6ae/output.txt Total script time: 33.45 mins
Image differences available at: http://54.67.70.0:8877/d7a406e0711f6ae/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/997b4d069de1994/output.txt Total script time: 39.14 mins
Image differences available at: http://3.101.106.178:8877/997b4d069de1994/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 30, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional details.
Also, note that this patch-series still leaves the
PDFWorkerClosureintact. The reason is partly that the code is less straightforward to re-factor in this way, and more importantly thatPDFWorkeris exposed in the public API and I really didn't want to accidentally make any internal state visible to the outside. This could possibly be improved upon if/when we've started using static class fields (currently blocked on ESLint support).