Remove the, strictly unnecessary, closure and variable shadowing from createObjectURL
#13021
Conversation
… `createObjectURL` Note that this particular helper function is, with the exception of the `GENERIC` default viewer and the (unsupported) SVG-backend, mostly unused at this point in time. Hence we should be able to clean-up this helper function slightly. Also, fixes a small inconsistency in the `SVGGraphics` initialization in the viewer, by passing in the `disableCreateObjectURL` compatibility-option. Given that the SVG-backend isn't officially supported/recommended this shouldn't have been an issue, but given that I spotted this it can't hurt to fix it.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e2b7f68c964756b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/755ec26c6746826/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/e2b7f68c964756b/output.txt Total script time: 23.96 mins
Image differences available at: http://54.67.70.0:8877/e2b7f68c964756b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/755ec26c6746826/output.txt Total script time: 29.39 mins
Image differences available at: http://3.101.106.178:8877/755ec26c6746826/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 2 Live output at: http://54.67.70.0:8877/c1bc1cef14d01bb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c1bc1cef14d01bb/output.txt Total script time: 4.07 mins Published |
|
Looks good! |
Note that this particular helper function is, with the exception of the
GENERICdefault viewer and the (unsupported) SVG-backend, mostly unused at this point in time. Hence we should be able to clean-up this helper function slightly.Also, fixes a small inconsistency in the
SVGGraphicsinitialization in the viewer, by passing in thedisableCreateObjectURLcompatibility-option. Given that the SVG-backend isn't officially supported/recommended this shouldn't have been an issue, but given that I spotted this it can't hurt to fix it.