Remove the NullL10n default value from viewer components not included in the COMPONENTS-bundle
#13020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in the `COMPONENTS`-bundle For any viewer component not listed in `web/pdf_viewer.component.js`, it shouldn't be necessary to provide a default value for the `l10n`-parameters. Note also that these *specific* components are heavily tailored towards the default viewer use-case, rather than for general usage.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/aae2e5e281f4c95/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/aae2e5e281f4c95/output.txt Total script time: 4.12 mins Published |
timvandermeij
approved these changes
Feb 25, 2021
|
I also don't see a good reason to keep this around. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any viewer component not listed in
web/pdf_viewer.component.js, it shouldn't be necessary to provide a default value for thel10n-parameters.Note also that these specific components are heavily tailored towards the default viewer use-case, rather than for general usage.