Skip to content

[api-minor] JS -- hidden annotations must be built in case a script show them #12567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

calixteman
Copy link
Contributor

  • in some pdf, there are actions with "event.source.hidden = ..."
  • in order to handle visibility when printing, annotationStorage is extended to store multiple properties (value, hidden, editable, ...)

@Snuffleupagus
Copy link
Collaborator

Given that this changes the format used internally in the AnnotationStorage, it's probably best to tag this PR with [api-minor] just in case someone has started to depend on it; that way it's easier to spot PRs with breaking changes when looking at https://github.com/mozilla/pdf.js/releases

@calixteman calixteman changed the title JS -- hidden annotations must be built in case a script show them [api-minor] JS -- hidden annotations must be built in case a script show them Nov 4, 2020
@brendandahl
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8a8f170cff39838/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/c30dd0ef86759c4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/8a8f170cff39838/output.txt

Total script time: 24.86 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/8a8f170cff39838/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/c30dd0ef86759c4/output.txt

Total script time: 29.92 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/c30dd0ef86759c4/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

Are you expecting the changes in issue4914-page1 and ZapfDingbats-page1? I'm not sure what behavior we want since chrome/acrobat/preview all seem to show different things.

 * in some pdf, there are actions with "event.source.hidden = ..."
 * in order to handle visibility when printing, annotationStorage is extended to store multiple properties (value, hidden, editable, ...)
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/3562ddb99e93f10/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/88569c59a79f981/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/88569c59a79f981/output.txt

Total script time: 26.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/88569c59a79f981/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/3562ddb99e93f10/output.txt

Total script time: 31.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/3562ddb99e93f10/reftest-analyzer.html#web=eq.log

@brendandahl brendandahl merged commit 4ba28de into mozilla:master Nov 19, 2020
@timvandermeij timvandermeij removed their request for review December 10, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants