Skip to content

Fix Rebind for Raw Datapath #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Fix Rebind for Raw Datapath #5090

merged 1 commit into from
May 12, 2025

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented May 10, 2025

Description

Recent onboarding of the interop over XDP exposed an issue with the RAW datapath and the rebind scenario. The route was kept as resolved, but it was clearing the queue, which would later crash on send. This fix clears the resolved state to force a new route resolution.

Testing

Validated locally over XDP. CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner May 10, 2025 13:47
@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label May 10, 2025
@nibanks nibanks enabled auto-merge (squash) May 10, 2025 13:48
Copy link

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.59%. Comparing base (f7890e3) to head (a2388e5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/connection.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5090      +/-   ##
==========================================
- Coverage   87.00%   86.59%   -0.42%     
==========================================
  Files          59       59              
  Lines       18035    18036       +1     
==========================================
- Hits        15692    15618      -74     
- Misses       2343     2418      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nibanks nibanks merged commit 8ab7065 into main May 12, 2025
330 of 335 checks passed
@nibanks nibanks deleted the raw-data-rebind branch May 12, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants