From 8ba77f1289fd4a8aff18bae3de7b644556064d14 Mon Sep 17 00:00:00 2001 From: Jeyachandran Rathnam Date: Sun, 18 Dec 2022 17:25:49 -0500 Subject: [PATCH 1/5] fixes #3982 : Check sqlite db file exists before porting --- synapse/_scripts/synapse_port_db.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/_scripts/synapse_port_db.py b/synapse/_scripts/synapse_port_db.py index d850e54e1751..c463b60b2620 100755 --- a/synapse/_scripts/synapse_port_db.py +++ b/synapse/_scripts/synapse_port_db.py @@ -1307,7 +1307,7 @@ def main() -> None: sqlite_config = { "name": "sqlite3", "args": { - "database": args.sqlite_database, + "database": "file:{}?mode=rw".format(args.sqlite_database), "cp_min": 1, "cp_max": 1, "check_same_thread": False, From ea7963f0c8f59fb5b6b9746a8c8eacccbb2641ea Mon Sep 17 00:00:00 2001 From: Jeyachandran Rathnam Date: Sun, 18 Dec 2022 17:28:40 -0500 Subject: [PATCH 2/5] Add changelog file --- changelog.d/14692.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/14692.misc diff --git a/changelog.d/14692.misc b/changelog.d/14692.misc new file mode 100644 index 000000000000..1b7809ec9c45 --- /dev/null +++ b/changelog.d/14692.misc @@ -0,0 +1 @@ +Check sqlite DB file exists before porting. \ No newline at end of file From 70d8a0a5e0f555e006d7ddf462d7b5df7d041a8c Mon Sep 17 00:00:00 2001 From: Jeyachandran Rathnam Date: Wed, 21 Dec 2022 12:47:33 -0500 Subject: [PATCH 3/5] Change sqllite DB file permissions from read-write to read-only --- synapse/_scripts/synapse_port_db.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/_scripts/synapse_port_db.py b/synapse/_scripts/synapse_port_db.py index c463b60b2620..4e5ee00e7802 100755 --- a/synapse/_scripts/synapse_port_db.py +++ b/synapse/_scripts/synapse_port_db.py @@ -1307,7 +1307,7 @@ def main() -> None: sqlite_config = { "name": "sqlite3", "args": { - "database": "file:{}?mode=rw".format(args.sqlite_database), + "database": "file:{}?mode=ro".format(args.sqlite_database), "cp_min": 1, "cp_max": 1, "check_same_thread": False, From a4834588d6d1b51dc5a5b42ad62b7f699f668988 Mon Sep 17 00:00:00 2001 From: Jeyachandran Rathnam Date: Thu, 22 Dec 2022 12:39:30 -0500 Subject: [PATCH 4/5] Change sqlite database permission from read-only to read-write --- synapse/_scripts/synapse_port_db.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/_scripts/synapse_port_db.py b/synapse/_scripts/synapse_port_db.py index 4e5ee00e7802..c463b60b2620 100755 --- a/synapse/_scripts/synapse_port_db.py +++ b/synapse/_scripts/synapse_port_db.py @@ -1307,7 +1307,7 @@ def main() -> None: sqlite_config = { "name": "sqlite3", "args": { - "database": "file:{}?mode=ro".format(args.sqlite_database), + "database": "file:{}?mode=rw".format(args.sqlite_database), "cp_min": 1, "cp_max": 1, "check_same_thread": False, From 9b25d491c1b4ebbc1381310560054db2e8a5c0f9 Mon Sep 17 00:00:00 2001 From: Patrick Cloke Date: Thu, 22 Dec 2022 12:51:38 -0500 Subject: [PATCH 5/5] Update changelog. --- changelog.d/14692.misc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/14692.misc b/changelog.d/14692.misc index 1b7809ec9c45..0edac253b7ff 100644 --- a/changelog.d/14692.misc +++ b/changelog.d/14692.misc @@ -1 +1 @@ -Check sqlite DB file exists before porting. \ No newline at end of file +Check that the SQLite database file exists before porting to PostgreSQL. \ No newline at end of file