Skip to content

Commit bc0b91c

Browse files
committed
usb: Rename usb_device struct member 'dev' to more appropriate 'handle'
1 parent 243dedf commit bc0b91c

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

src/usb.c

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
#define NUM_RX_LOOPS 3
5454

5555
struct usb_device {
56-
libusb_device_handle *dev;
56+
libusb_device_handle *handle;
5757
uint8_t bus, address;
5858
char serial[256];
5959
int alive;
@@ -83,7 +83,7 @@ static int device_hotplug = 1;
8383

8484
static void usb_disconnect(struct usb_device *dev)
8585
{
86-
if(!dev->dev) {
86+
if(!dev->handle) {
8787
return;
8888
}
8989

@@ -114,9 +114,9 @@ static void usb_disconnect(struct usb_device *dev)
114114

115115
collection_free(&dev->tx_xfers);
116116
collection_free(&dev->rx_xfers);
117-
libusb_release_interface(dev->dev, dev->interface);
118-
libusb_close(dev->dev);
119-
dev->dev = NULL;
117+
libusb_release_interface(dev->handle, dev->interface);
118+
libusb_close(dev->handle);
119+
dev->handle = NULL;
120120
collection_remove(&device_list, dev);
121121
free(dev);
122122
}
@@ -177,7 +177,7 @@ int usb_send(struct usb_device *dev, const unsigned char *buf, int length)
177177
{
178178
int res;
179179
struct libusb_transfer *xfer = libusb_alloc_transfer(0);
180-
libusb_fill_bulk_transfer(xfer, dev->dev, dev->ep_out, (void*)buf, length, tx_callback, dev, 0);
180+
libusb_fill_bulk_transfer(xfer, dev->handle, dev->ep_out, (void*)buf, length, tx_callback, dev, 0);
181181
if((res = libusb_submit_transfer(xfer)) < 0) {
182182
usbmuxd_log(LL_ERROR, "Failed to submit TX transfer %p len %d to device %d-%d: %s", buf, length, dev->bus, dev->address, libusb_error_name(res));
183183
libusb_free_transfer(xfer);
@@ -189,7 +189,7 @@ int usb_send(struct usb_device *dev, const unsigned char *buf, int length)
189189
// Send Zero Length Packet
190190
xfer = libusb_alloc_transfer(0);
191191
void *buffer = malloc(1);
192-
libusb_fill_bulk_transfer(xfer, dev->dev, dev->ep_out, buffer, 0, tx_callback, dev, 0);
192+
libusb_fill_bulk_transfer(xfer, dev->handle, dev->ep_out, buffer, 0, tx_callback, dev, 0);
193193
if((res = libusb_submit_transfer(xfer)) < 0) {
194194
usbmuxd_log(LL_ERROR, "Failed to submit TX ZLP transfer to device %d-%d: %s", dev->bus, dev->address, libusb_error_name(res));
195195
libusb_free_transfer(xfer);
@@ -256,7 +256,7 @@ static int start_rx_loop(struct usb_device *dev)
256256
void *buf;
257257
struct libusb_transfer *xfer = libusb_alloc_transfer(0);
258258
buf = malloc(USB_MRU);
259-
libusb_fill_bulk_transfer(xfer, dev->dev, dev->ep_in, buf, USB_MRU, rx_callback, dev, 0);
259+
libusb_fill_bulk_transfer(xfer, dev->handle, dev->ep_in, buf, USB_MRU, rx_callback, dev, 0);
260260
if((res = libusb_submit_transfer(xfer)) != 0) {
261261
usbmuxd_log(LL_ERROR, "Failed to submit RX transfer to device %d-%d: %s", dev->bus, dev->address, libusb_error_name(res));
262262
libusb_free_transfer(xfer);
@@ -357,7 +357,7 @@ static void get_langid_callback(struct libusb_transfer *transfer)
357357
libusb_fill_control_setup(transfer->buffer, LIBUSB_ENDPOINT_IN, LIBUSB_REQUEST_GET_DESCRIPTOR,
358358
(uint16_t)((LIBUSB_DT_STRING << 8) | usbdev->devdesc.iSerialNumber),
359359
langid, 1024 + LIBUSB_CONTROL_SETUP_SIZE);
360-
libusb_fill_control_transfer(transfer, usbdev->dev, transfer->buffer, get_serial_callback, usbdev, 1000);
360+
libusb_fill_control_transfer(transfer, usbdev->handle, transfer->buffer, get_serial_callback, usbdev, 1000);
361361

362362
if((res = libusb_submit_transfer(transfer)) < 0) {
363363
usbmuxd_log(LL_ERROR, "Could not request transfer for device %d-%d: %s", usbdev->bus, usbdev->address, libusb_error_name(res));
@@ -595,7 +595,7 @@ static void device_complete_initialization(struct mode_context *context, struct
595595
usbdev->address = address;
596596
usbdev->devdesc = devdesc;
597597
usbdev->speed = 480000000;
598-
usbdev->dev = handle;
598+
usbdev->handle = handle;
599599
usbdev->alive = 1;
600600
usbdev->wMaxPacketSize = libusb_get_max_packet_size(dev, usbdev->ep_out);
601601
if (usbdev->wMaxPacketSize <= 0) {
@@ -764,7 +764,7 @@ static int usb_device_add(libusb_device* dev)
764764
usbdev->address = address;
765765
usbdev->devdesc = devdesc;
766766
usbdev->speed = 0;
767-
usbdev->dev = handle;
767+
usbdev->handle = handle;
768768
usbdev->alive = 1;
769769

770770
collection_init(&usbdev->tx_xfers);
@@ -854,31 +854,31 @@ int usb_discover(void)
854854

855855
const char *usb_get_serial(struct usb_device *dev)
856856
{
857-
if(!dev->dev) {
857+
if(!dev->handle) {
858858
return NULL;
859859
}
860860
return dev->serial;
861861
}
862862

863863
uint32_t usb_get_location(struct usb_device *dev)
864864
{
865-
if(!dev->dev) {
865+
if(!dev->handle) {
866866
return 0;
867867
}
868868
return (dev->bus << 16) | dev->address;
869869
}
870870

871871
uint16_t usb_get_pid(struct usb_device *dev)
872872
{
873-
if(!dev->dev) {
873+
if(!dev->handle) {
874874
return 0;
875875
}
876876
return dev->devdesc.idProduct;
877877
}
878878

879879
uint64_t usb_get_speed(struct usb_device *dev)
880880
{
881-
if (!dev->dev) {
881+
if (!dev->handle) {
882882
return 0;
883883
}
884884
return dev->speed;

0 commit comments

Comments
 (0)