Leak EventHandler

[calvinhsia]

Analyzing 40 customer dumps

EvHandler	EvType	PctCabs	CabCnt	AvgNumEVH	MaxNumEVH	Notes	Link
System.EventHandler GitDiffMargin.Core.MarginCore.BrushesChanged += GitDiffMargin.ViewModel.ScrollDiffViewModel	MultipleEventHandlers	1.2	40	277	1596	https://github.com/laurentkempe/GitDiffMargin
System.EventHandler GitDiffMargin.Core.MarginCore.BrushesChanged += GitDiffMargin.ViewModel.EditorDiffViewModel	MultipleEventHandlers	1.2	40	277	1596	https://github.com/laurentkempe/GitDiffMargin

The MarginCore publishes a BrushesChanged event, and the ScrollDiffViewModel and the EditorDiffViewModel subscribe and handle the event, but never unsubscribe.
Thus an average of 277 event subscriptions in each VS session (max 1596) occurs.

Versions

• Git Diff Margin version: ...
• Visual Studio version: ...

What happened

Steps to Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Screenshots

Logs

Additional context

[laurentkempe]

Thx for the report @calvinhsia I will take a look at it!