From 4ea3b832674a06ce155b56c1bc09a35f9d134ec3 Mon Sep 17 00:00:00 2001 From: Chris Zubak-Skees Date: Sat, 8 Jun 2024 17:28:29 +0800 Subject: [PATCH] fix: explicitly convert iOS volume to double Fixes a conversion issue which made setVolume fail in some cases Closes #43 --- ios/RNJWPlayer/RNJWPlayerViewManager.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ios/RNJWPlayer/RNJWPlayerViewManager.swift b/ios/RNJWPlayer/RNJWPlayerViewManager.swift index 68e4812..a8f6107 100644 --- a/ios/RNJWPlayer/RNJWPlayerViewManager.swift +++ b/ios/RNJWPlayer/RNJWPlayerViewManager.swift @@ -172,7 +172,7 @@ class RNJWPlayerViewManager: RCTViewManager { } } - @objc func setVolume(_ reactTag: NSNumber, _ volume: Double) { + @objc func setVolume(_ reactTag: NSNumber, _ volume: NSNumber) { self.bridge.uiManager.addUIBlock { uiManager, viewRegistry in guard let view = viewRegistry?[reactTag] as? RNJWPlayerView else { print("Invalid view returned from registry, expecting RNJWPlayerView, got: \(String(describing: viewRegistry?[reactTag]))") @@ -180,9 +180,9 @@ class RNJWPlayerViewManager: RCTViewManager { } if let playerView = view.playerView { - playerView.player.volume = volume + playerView.player.volume = volume.doubleValue } else if let playerViewController = view.playerViewController { - playerViewController.player.volume = volume + playerViewController.player.volume = volume.doubleValue } } }