Fix compatibility issue with Openfire 4.9.0 #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Openfire API usage that was deprecated in Openfire 4.8.0 and removed in 4.9.0. This plugin is now compatible with Openfire 4.9.0 and requires 4.8.0 or later. No longer compatible with versions older than 4.8.0. fixes igniterealtime#387
|
I think the ssl repo issue for jrobin is fixed now, at least, but that does not seem to be the issue here, but will try pushing a change |
akrherz
force-pushed
the
387_Openfire-4.9.0-compat
branch
from
494c586 to
ed6fc9d
Compare
|
The OpenNMS repo appears empty / defunct. I found a forked jrobin on github, so why not... |
Fishbowler
previously approved these changes
Aug 24, 2024
src/java/org/jivesoftware/openfire/plugin/MonitoringPlugin.java
Outdated
Show resolved
Hide resolved
The enterprise plugin is long, long gone and would unlikely to be compatible with any modern (or even most old and ancient) version of Openfire. This comit removes the explicit check for its existence.
akrherz
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Openfire API usage that was deprecated in Openfire 4.8.0 and removed in 4.9.0.
This plugin is now compatible with Openfire 4.9.0 and requires 4.8.0 or later. No longer compatible with versions older than 4.8.0.
fixes #387