From 2762360cefdf4ed420ebdf0ea0530fd2e47847cf Mon Sep 17 00:00:00 2001 From: Ivo Yankov Date: Mon, 17 Feb 2025 11:53:38 +0200 Subject: [PATCH 1/4] fix: properties of undefined error Signed-off-by: Ivo Yankov --- src/commands/network.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/commands/network.ts b/src/commands/network.ts index 7d445a38d..5660399b2 100644 --- a/src/commands/network.ts +++ b/src/commands/network.ts @@ -850,13 +850,14 @@ export class NetworkCommand extends BaseCommand { `solo.hedera.com/node-id=${consensusNode.nodeId},solo.hedera.com/type=network-node-svc`, ]); - if (svc && svc.length > 0 && svc[0].status.loadBalancer.ingress.length > 0) { + if (svc && svc.length > 0 && svc[0].status?.loadBalancer?.ingress?.length > 0) { return; } attempts++; await helpers.sleep(Duration.ofSeconds(2)); } + throw new SoloError('Load balancer not found'); }, }); } From 260d41ac7df0ea8d933baff20152503a6bdf8882 Mon Sep 17 00:00:00 2001 From: Ivo Yankov Date: Mon, 17 Feb 2025 15:45:31 +0200 Subject: [PATCH 2/4] fix: check for ingress hostname or ip Signed-off-by: Ivo Yankov --- src/commands/network.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/commands/network.ts b/src/commands/network.ts index 5660399b2..ac329900d 100644 --- a/src/commands/network.ts +++ b/src/commands/network.ts @@ -851,7 +851,12 @@ export class NetworkCommand extends BaseCommand { ]); if (svc && svc.length > 0 && svc[0].status?.loadBalancer?.ingress?.length > 0) { - return; + for (let i = 0; i < svc.status.loadBalancer.ingress.length; i++) { + const ingress = svc.status.loadBalancer.ingress[i]; + if (ingress.hostname || ingress.ip) { + return; + } + } } attempts++; From f24f9216560720ad8935f5c4a93de6511e999efe Mon Sep 17 00:00:00 2001 From: Ivo Yankov Date: Mon, 17 Feb 2025 15:50:33 +0200 Subject: [PATCH 3/4] fix: check for ingress hostname or ip Signed-off-by: Ivo Yankov --- src/commands/network.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/commands/network.ts b/src/commands/network.ts index ac329900d..a671c458a 100644 --- a/src/commands/network.ts +++ b/src/commands/network.ts @@ -851,12 +851,18 @@ export class NetworkCommand extends BaseCommand { ]); if (svc && svc.length > 0 && svc[0].status?.loadBalancer?.ingress?.length > 0) { + let shouldContinue = false; for (let i = 0; i < svc.status.loadBalancer.ingress.length; i++) { const ingress = svc.status.loadBalancer.ingress[i]; - if (ingress.hostname || ingress.ip) { - return; + if (!ingress.hostname && !ingress.ip) { + shouldContinue = true; // try again if there is neither a hostname nor an ip + break; } } + if (shouldContinue) { + continue; + } + return; } attempts++; From bf363cd3d069a85b9743c4825798d9a21663a331 Mon Sep 17 00:00:00 2001 From: Ivo Yankov Date: Mon, 17 Feb 2025 16:08:37 +0200 Subject: [PATCH 4/4] fix: add svc index Signed-off-by: Ivo Yankov --- src/commands/network.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/commands/network.ts b/src/commands/network.ts index a671c458a..b32d8f08e 100644 --- a/src/commands/network.ts +++ b/src/commands/network.ts @@ -852,8 +852,8 @@ export class NetworkCommand extends BaseCommand { if (svc && svc.length > 0 && svc[0].status?.loadBalancer?.ingress?.length > 0) { let shouldContinue = false; - for (let i = 0; i < svc.status.loadBalancer.ingress.length; i++) { - const ingress = svc.status.loadBalancer.ingress[i]; + for (let i = 0; i < svc[0].status.loadBalancer.ingress.length; i++) { + const ingress = svc[0].status.loadBalancer.ingress[i]; if (!ingress.hostname && !ingress.ip) { shouldContinue = true; // try again if there is neither a hostname nor an ip break;