Skip to content

Commit 6d225e6

Browse files
committed
fix(lib): remove circular refs in IoService
fix #480
1 parent b91c9ae commit 6d225e6

16 files changed

+19
-16
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import { ComponentRef } from '@angular/core';
2+
3+
export interface DynamicComponentInjector {
4+
componentRef: ComponentRef<unknown> | null;
5+
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1+
export * from './component-injector';
12
export * from './token';
2-
export * from './component-outlet';
Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
import { ComponentRef, InjectionToken } from '@angular/core';
2-
3-
export interface DynamicComponentInjector {
4-
componentRef: ComponentRef<unknown> | null;
5-
}
1+
import { InjectionToken } from '@angular/core';
2+
import { DynamicComponentInjector } from './component-injector';
63

74
export const DynamicComponentInjectorToken =
85
new InjectionToken<DynamicComponentInjector>('DynamicComponentInjector');
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable @angular-eslint/component-selector */
22
import { Component, ComponentRef, Type, ViewChild } from '@angular/core';
3-
import { TestSetup } from '../../../test';
3+
import { TestSetup } from '../../test';
44
import { ComponentOutletInjectorDirective } from './component-outlet-injector.directive';
55

66
describe('ComponentOutletInjectorDirective', () => {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ComponentRef, Directive, Host } from '@angular/core';
44
import {
55
DynamicComponentInjector,
66
DynamicComponentInjectorToken,
7-
} from '../token';
7+
} from '../component-injector';
88

99
@Directive({
1010
// eslint-disable-next-line @angular-eslint/directive-selector
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable @angular-eslint/component-selector */
22
import { Component, EventEmitter, Input, Output, Type } from '@angular/core';
3-
import { TestSetup } from '../../../test';
3+
import { TestSetup } from '../../test';
44
import { ComponentOutletInjectorDirective } from './component-outlet-injector.directive';
55
import { ComponentOutletIoDirective } from './component-outlet-io.directive';
66

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Directive, DoCheck, Input } from '@angular/core';
22

3-
import { InputsType, IoService, OutputsType } from '../../io';
3+
import { InputsType, IoService, OutputsType } from '../io';
44

55
@Directive({
66
selector:

projects/ng-dynamic-component/src/lib/dynamic-attributes/dynamic-attributes.directive.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* eslint-disable @angular-eslint/component-selector */
22
import { Component, Type } from '@angular/core';
33
import { TestFixture, TestSetup } from '../../test';
4-
import { ComponentOutletInjectorDirective } from '../component-injector';
4+
import { ComponentOutletInjectorDirective } from '../component-outlet';
55
import { DynamicComponent as NdcDynamicComponent } from '../dynamic.component';
66
import {
77
AttributesMap,

projects/ng-dynamic-component/src/lib/dynamic-attributes/dynamic-attributes.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { CommonModule } from '@angular/common';
22
import { NgModule } from '@angular/core';
33

4-
import { ComponentOutletInjectorModule } from '../component-injector';
4+
import { ComponentOutletInjectorModule } from '../component-outlet';
55
import { DynamicAttributesDirective } from './dynamic-attributes.directive';
66

77
@NgModule({

projects/ng-dynamic-component/src/lib/dynamic-directives/dynamic-directives.directive.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
} from '@angular/core';
2323

2424
import { TestFixture, TestSetup } from '../../test';
25-
import { ComponentOutletInjectorDirective } from '../component-injector';
25+
import { ComponentOutletInjectorDirective } from '../component-outlet';
2626
import { DynamicComponent as NdcDynamicComponent } from '../dynamic.component';
2727
import { IoFactoryService } from '../io';
2828
import {

projects/ng-dynamic-component/src/lib/dynamic-directives/dynamic-directives.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { CommonModule } from '@angular/common';
22
import { NgModule } from '@angular/core';
33

4-
import { ComponentOutletInjectorModule } from '../component-injector';
4+
import { ComponentOutletInjectorModule } from '../component-outlet';
55
import { DynamicDirectivesDirective } from './dynamic-directives.directive';
66

77
@NgModule({

projects/ng-dynamic-component/src/lib/dynamic-io/dynamic-io.directive.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
import { TestBed } from '@angular/core/testing';
1818
import { By } from '@angular/platform-browser';
1919
import { TestFixture, TestSetup } from '../../test';
20-
import { ComponentOutletInjectorModule } from '../component-injector';
20+
import { ComponentOutletInjectorModule } from '../component-outlet';
2121
import { DynamicComponent as NdcDynamicComponent } from '../dynamic.component';
2222
import { InputsType, IoEventArgumentToken, OutputsType } from '../io';
2323
import {

projects/ng-dynamic-component/src/lib/dynamic-io/dynamic-io.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { CommonModule } from '@angular/common';
22
import { NgModule } from '@angular/core';
33

4-
import { ComponentOutletInjectorModule } from '../component-injector';
4+
import { ComponentOutletInjectorModule } from '../component-outlet';
55
import { DynamicIoDirective } from './dynamic-io.directive';
66

77
@NgModule({

projects/ng-dynamic-component/src/public-api.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
export * from './lib/io';
66
export * from './lib/component-injector';
7+
export * from './lib/component-outlet';
78
export * from './lib/dynamic.module';
89
export * from './lib/dynamic.component';
910
export * from './lib/dynamic-io';

0 commit comments

Comments
 (0)