Skip to content

Commit 3bb75d9

Browse files
authored
fix: enable a11y eslint rules (#968)
* fix: enable a11y eslint rules * fix: comments fixies
1 parent 7b6b268 commit 3bb75d9

File tree

15 files changed

+1183
-687
lines changed

15 files changed

+1183
-687
lines changed

.eslintrc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
{
2-
"extends": ["@gravity-ui/eslint-config", "@gravity-ui/eslint-config/prettier"],
2+
"extends": [
3+
"@gravity-ui/eslint-config",
4+
"@gravity-ui/eslint-config/prettier",
5+
"@gravity-ui/eslint-config/a11y"
6+
],
37
"root": true,
48
"env": {
59
"node": true,

package-lock.json

Lines changed: 1137 additions & 683 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
"@commitlint/cli": "^17.1.2",
125125
"@commitlint/config-conventional": "^17.1.0",
126126
"@diplodoc/transform": "^4.10.8",
127-
"@gravity-ui/eslint-config": "^2.0.0",
127+
"@gravity-ui/eslint-config": "^2.2.0",
128128
"@gravity-ui/icons": "^2.8.1",
129129
"@gravity-ui/prettier-config": "^1.0.1",
130130
"@gravity-ui/stylelint-config": "^1.0.0",

src/blocks/Questions/QuestionBlockItem/QuestionBlockItem.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ export const QuestionBlockItem = ({
3434
className={b('title')}
3535
onClick={onClick}
3636
aria-expanded={isOpened}
37+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/966
38+
// eslint-disable-next-line jsx-a11y/no-noninteractive-element-to-interactive-role
3739
role={'button'}
3840
tabIndex={0}
3941
onKeyDown={onKeyDown}

src/components/DefaultVideo/DefaultVideo.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* eslint-disable jsx-a11y/media-has-caption */
2+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/967
13
import React, {Fragment, useCallback, useImperativeHandle, useRef, useState} from 'react';
24

35
import {CustomControlsType, MediaVideoControlsType, MediaVideoProps} from '../../models';

src/components/ImageBase/ImageBase.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export interface ImageBaseProps extends Partial<ImageObjectProps> {
1414
export const ImageBase = (props: ImageBaseProps) => {
1515
const {Image} = React.useContext(ImageContext);
1616

17+
// eslint-disable-next-line jsx-a11y/alt-text
1718
return Image ? <Image {...props} /> : <img {...props} />;
1819
};
1920

src/components/Map/__stories__/ApiKeyInput.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ interface ApiKeyInputProps {
1111
id: string;
1212
}
1313

14+
const inputID = 'apikey-input';
15+
1416
export const ApiKeyInput = (props: ApiKeyInputProps) => {
1517
const {id} = props;
1618
const [apiKey, setApiKey] = useState<string>(localStorage?.getItem(id) || '');
@@ -31,9 +33,12 @@ export const ApiKeyInput = (props: ApiKeyInputProps) => {
3133

3234
return (
3335
<div>
34-
<label style={{display: 'block'}}>Api key for google maps</label>
36+
<label style={{display: 'block'}} htmlFor={inputID}>
37+
Api key for google maps
38+
</label>
3539
<div style={{display: 'flex'}}>
3640
<TextInput
41+
id={inputID}
3742
type="text"
3843
className="apikey-input"
3944
value={apiKey}

src/components/OutsideClick/OutsideClick.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
//TODO move into cloud components?
26
import React, {PropsWithChildren, createRef} from 'react';
37

src/components/ReactPlayer/ReactPlayer.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
import React, {
26
Fragment,
37
useCallback,

src/components/Title/TitleItem.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
import React, {Fragment, ReactNode, useContext} from 'react';
26

37
import {HTML, ToggleArrow} from '../';

src/components/VideoBlock/VideoBlock.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
import React, {useCallback, useEffect, useRef, useState} from 'react';
26

37
import {PlayFill} from '@gravity-ui/icons';

src/editor/components/AddBlock/AddBlock.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
import React, {PropsWithChildren, useMemo, useRef, useState} from 'react';
26

37
import {Plus} from '@gravity-ui/icons';

src/editor/components/EditBlock/EditBlock.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
import React, {useEffect, useRef} from 'react';
26

37
import {ChevronDown, ChevronUp, Copy as CopyIcon, TrashBin} from '@gravity-ui/icons';

src/navigation/__stories__/CustomComponent/CustomComponent.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
/* eslint-disable jsx-a11y/no-static-element-interactions */
2+
/* eslint-disable jsx-a11y/click-events-have-key-events */
3+
// TODO fix in https://github.com/gravity-ui/page-constructor/issues/965
4+
15
import React from 'react';
26

37
import {cn} from '../../../utils';

src/sub-blocks/PriceDetailed/PriceDetails/Details/List.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const List = (props: ListProps) => {
2020
<Fragment>
2121
{items.map((item, id) => (
2222
<div key={id} className={b('list-item')}>
23-
<img className={b('img')} />
23+
<img className={b('img')} alt="" />
2424
<div className={b('text', {size: titleSize})}>
2525
<YFMWrapper content={item.text} modifiers={{constructor: true}} />
2626
</div>

0 commit comments

Comments
 (0)