From 89a172aec9dc568ec6dcdf0e1694f7d86263b094 Mon Sep 17 00:00:00 2001 From: Dimitri POSTOLOV Date: Thu, 25 Jul 2024 10:04:03 +0200 Subject: [PATCH 1/2] aa --- .changeset/tidy-fans-reflect.md | 7 +++++++ packages/graphiql-plugin-code-exporter/vite.config.ts | 1 + packages/graphiql-plugin-explorer/vite.config.ts | 1 + packages/graphiql-react/vite.config.ts | 6 +----- 4 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .changeset/tidy-fans-reflect.md diff --git a/.changeset/tidy-fans-reflect.md b/.changeset/tidy-fans-reflect.md new file mode 100644 index 00000000000..75e97c126f8 --- /dev/null +++ b/.changeset/tidy-fans-reflect.md @@ -0,0 +1,7 @@ +--- +"@graphiql/plugin-code-exporter": patch +"@graphiql/plugin-explorer": patch +"@graphiql/react": patch +--- + +set `build.minify: false` for cjs/esm builds since minified variable names changes every time diff --git a/packages/graphiql-plugin-code-exporter/vite.config.ts b/packages/graphiql-plugin-code-exporter/vite.config.ts index 7db8ba68dcc..b963a34933f 100644 --- a/packages/graphiql-plugin-code-exporter/vite.config.ts +++ b/packages/graphiql-plugin-code-exporter/vite.config.ts @@ -7,6 +7,7 @@ const IS_UMD = process.env.UMD === 'true'; export default defineConfig({ plugins: [react({ jsxRuntime: 'classic' })], build: { + minify: IS_UMD ? 'esbuild' : false, // avoid clean cjs/es builds emptyOutDir: !IS_UMD, lib: { diff --git a/packages/graphiql-plugin-explorer/vite.config.ts b/packages/graphiql-plugin-explorer/vite.config.ts index 1d5c67ddf62..e47ea748b70 100644 --- a/packages/graphiql-plugin-explorer/vite.config.ts +++ b/packages/graphiql-plugin-explorer/vite.config.ts @@ -16,6 +16,7 @@ export default defineConfig({ }), ], build: { + minify: IS_UMD ? 'esbuild' : false, // avoid clean cjs/es builds emptyOutDir: !IS_UMD, lib: { diff --git a/packages/graphiql-react/vite.config.ts b/packages/graphiql-react/vite.config.ts index 08df2c79573..fb552395aaf 100644 --- a/packages/graphiql-react/vite.config.ts +++ b/packages/graphiql-react/vite.config.ts @@ -19,12 +19,8 @@ export default defineConfig({ plugins: [postCssNestingPlugin()], }, }, - esbuild: { - // We use function names for generating readable error messages, so we want - // them to be preserved when building and minifying. - keepNames: true, - }, build: { + minify: false, sourcemap: true, lib: { entry: 'src/index.ts', From 8e7393053b8b2d02a9e8973e52f8431578954ce1 Mon Sep 17 00:00:00 2001 From: Dimitri POSTOLOV Date: Thu, 25 Jul 2024 11:19:14 +0200 Subject: [PATCH 2/2] Update .changeset/tidy-fans-reflect.md --- .changeset/tidy-fans-reflect.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/tidy-fans-reflect.md b/.changeset/tidy-fans-reflect.md index 75e97c126f8..3f08a9261e2 100644 --- a/.changeset/tidy-fans-reflect.md +++ b/.changeset/tidy-fans-reflect.md @@ -4,4 +4,4 @@ "@graphiql/react": patch --- -set `build.minify: false` for cjs/esm builds since minified variable names changes every time +set `build.minify: false` for cjs/esm builds since minified variable names change every build time