Skip to content

chore(v2): refactor experiment package #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 4, 2025
Merged

chore(v2): refactor experiment package #4281

merged 8 commits into from
Jul 4, 2025

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Jul 4, 2025 •
edited
Loading

This PR removes the experiment package, where we incubated our v2 components. The new components have been moved to the root pkg directory.

I've also made some small refactorings:

  • Replaced underscores in package names, which is not idiomatic Go (as explicitly mentioned in the Google Go style guide – not canonical, but widely referenced).
  • Updated handling of the v2 environment variable: PYROSCOPE_V2 should be used from now on, though the old one is still supported for compatibility.
  • Renamed pkg/phlare to pkg/pyroscope.
  • Cleaned up generated mocks.
  • Fixed imports using goimports.
  • Updated v2 documentation and links.
  • Updated CODEOWNERS.

@kolesnikovae kolesnikovae force-pushed the chore/refactor-experiment-pkg branch from f3075dc to 13867c5 Compare July 4, 2025 05:50
@kolesnikovae kolesnikovae marked this pull request as ready for review July 4, 2025 08:16
@kolesnikovae kolesnikovae changed the title chore(v2): remove experiment package chore(v2): refactor experiment package Jul 4, 2025
@aleks-p aleks-p force-pushed the chore/refactor-experiment-pkg branch from fe2e42e to 63790ca Compare July 4, 2025 17:46
@aleks-p aleks-p enabled auto-merge (squash) July 4, 2025 17:47
@aleks-p aleks-p force-pushed the chore/refactor-experiment-pkg branch from 58c0bdf to 4234ea6 Compare July 4, 2025 18:14
@aleks-p aleks-p merged commit 0920249 into main Jul 4, 2025
24 checks passed
@aleks-p aleks-p deleted the chore/refactor-experiment-pkg branch July 4, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-p aleks-p aleks-p approved these changes

@simonswine simonswine Awaiting requested review from simonswine simonswine is a code owner

@alsoba13 alsoba13 Awaiting requested review from alsoba13 alsoba13 is a code owner

@korniltsev korniltsev Awaiting requested review from korniltsev korniltsev is a code owner

@marcsanmi marcsanmi Awaiting requested review from marcsanmi marcsanmi is a code owner

@bryanhuhta bryanhuhta Awaiting requested review from bryanhuhta bryanhuhta is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @aleks-p