Skip to content

Add OSS documentation on the Source Code GitHub integration #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Apr 22, 2025

This adds and adapts the grafana-cloud Github integration.

Let me know what you think?


## Verifying the Integration

The configuration of the GitHub integration is now completed. In order to verify everything works as expected follow the user guide: [Integrate your source code on GitHub with Pyroscope profiling data](../../view-and-analyze-profile-data/line-by-line/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The configuration of the GitHub integration is now completed. In order to verify everything works as expected follow the user guide: [Integrate your source code on GitHub with Pyroscope profiling data](../../view-and-analyze-profile-data/line-by-line/).
The configuration of the GitHub integration is now completed. In order to verify everything works as expected follow the user guide: [Integrate your source code on GitHub with Pyroscope profiling data](../view-and-analyze-profile-data/line-by-line.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct, at least when I use it 404s under make docs/docs. I do think the other link is wrong see 380ad7e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, .md apparently isn't needed; I think hugo already handled this. Forget about the relative path levels change, that wasn't intended.

@simonswine simonswine changed the title WIP: docs: Add OSS documentation on the GitHub integration Add OSS documentation on the GitHub integration Jun 18, 2025
@simonswine simonswine changed the title Add OSS documentation on the GitHub integration Add OSS documentation on the Source Code GitHub integration Jun 18, 2025
@simonswine simonswine marked this pull request as ready for review June 18, 2025 14:18
@simonswine simonswine requested review from a team as code owners June 18, 2025 14:18
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


This guide walks you through setting up the GitHub integration with minimal permissions for Grafana Pyroscope.

## Creating a GitHub App
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that all the steps are right here and broken down nicely. I think it might also be helpful to link to the GitHub app docs: https://docs.github.com/en/apps/creating-github-apps/registering-a-github-app/registering-a-github-app.

These will have more details and cover more edge cases than we might care to do here.

Comment on lines 42 to 43
- Applications in other languages aren't supported
- eBPF profiled workloads aren't supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we convert this to a warning admonition? It would help bring attention to the fact that other languages aren't supported (yet).

@simonswine simonswine force-pushed the 20250422_github-integration-docs branch from 2369b3f to 455a928 Compare June 18, 2025 16:13
@simonswine simonswine merged commit dbdcd4e into grafana:main Jun 18, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants