-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Adds multistep blocks to docs #1880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -262,7 +262,7 @@ def update(name): | |||
btn.click(fn=update, inputs=inp, outputs=out) | |||
|
|||
demo.launch() | |||
Demos: blocks_hello, blocks_flipper, blocks_speech_text_length, generate_english_german | |||
Demos: blocks_hello, blocks_flipper, blocks_speech_text_sentiment, generate_english_german |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I actually can't run this demo locally?
I get
raise ValueError("We expect a numpy ndarray as input")
Had to do
asr(speech[1].astype(float))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this -- speech
should be a filepath. What does speech[1].astype(float)
mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested on Spaces, and the code is running fine as it was written originally: https://huggingface.co/spaces/abidlabs/asr-test-pt
Is there something different on your local version of the demo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abidlabs could be a difference in my transformers version.
I can’t check cause I’m at the airport now. Feel free to merge, as long as the demo works on the website were good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, safe travels!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abidlabs Agree we don't need a whole guide but the demo you added doesn't work for me locally? Get an exception from transformers.
Adds a multistep demo to the new documentation around Blocks. I think this is sufficient to explain how a multistep block works, but if people feel like more explanation is needed, let me know!