diff --git a/.kokoro/continuous/e2e.cfg b/.kokoro/continuous/e2e.cfg index 7479346590..774b63313e 100644 --- a/.kokoro/continuous/e2e.cfg +++ b/.kokoro/continuous/e2e.cfg @@ -3,7 +3,7 @@ # Only run this nox session. env_vars: { key: "NOX_SESSION" - value: "unit_prerelease system_prerelease system_noextras e2e notebook samples" + value: "unit_prerelease system_prerelease system_noextras e2e notebook" } env_vars: { diff --git a/.kokoro/presubmit/e2e-gerrit.cfg b/.kokoro/presubmit/e2e-gerrit.cfg index d875f36060..19913344b6 100644 --- a/.kokoro/presubmit/e2e-gerrit.cfg +++ b/.kokoro/presubmit/e2e-gerrit.cfg @@ -3,5 +3,5 @@ # Only run this nox session. env_vars: { key: "NOX_SESSION" - value: "system_noextras e2e notebook samples" + value: "system_noextras e2e notebook" } diff --git a/.kokoro/presubmit/e2e.cfg b/.kokoro/presubmit/e2e.cfg index 7479346590..774b63313e 100644 --- a/.kokoro/presubmit/e2e.cfg +++ b/.kokoro/presubmit/e2e.cfg @@ -3,7 +3,7 @@ # Only run this nox session. env_vars: { key: "NOX_SESSION" - value: "unit_prerelease system_prerelease system_noextras e2e notebook samples" + value: "unit_prerelease system_prerelease system_noextras e2e notebook" } env_vars: { diff --git a/noxfile.py b/noxfile.py index 91ad6bc0e6..af73495a7f 100644 --- a/noxfile.py +++ b/noxfile.py @@ -402,26 +402,6 @@ def load(session: nox.sessions.Session): ) -@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS) -def samples(session): - """Run the samples test suite.""" - - constraints_path = str( - CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt" - ) - - # TODO(b/332735129): Remove this session and use python_samples templates - # where each samples directory has its own noxfile.py file, instead. - install_test_extra = True - install_systemtest_dependencies(session, install_test_extra, "-c", constraints_path) - - session.run( - "py.test", - "samples", - *session.posargs, - ) - - @nox.session(python=DEFAULT_PYTHON_VERSION) def cover(session): """Run the final coverage report. diff --git a/owlbot.py b/owlbot.py index f804859689..ddc578c3a2 100644 --- a/owlbot.py +++ b/owlbot.py @@ -74,7 +74,7 @@ import pandas import pyarrow import sqlglot - + print(f"Python: {sys.version}") print(f"bigframes=={bigframes.__version__}") print(f"google-cloud-bigquery=={google.cloud.bigquery.__version__}") @@ -83,7 +83,7 @@ print(f"pyarrow=={pyarrow.__version__}") print(f"sqlglot=={sqlglot.__version__}") ``` - + #### Steps to reproduce """, ), @@ -148,3 +148,5 @@ # ---------------------------------------------------------------------------- s.shell.run(["nox", "-s", "format"], hide_output=False) +for noxfile in REPO_ROOT.glob("samples/**/noxfile.py"): + s.shell.run(["nox", "-s", "format"], cwd=noxfile.parent, hide_output=False) diff --git a/samples/snippets/bqml_getting_started_test.py b/samples/snippets/bqml_getting_started_test.py index d9f9135faa..d249ca4ff3 100644 --- a/samples/snippets/bqml_getting_started_test.py +++ b/samples/snippets/bqml_getting_started_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bqml_getting_started(random_model_id): +def test_bqml_getting_started(random_model_id: str) -> None: your_model_id = random_model_id # for example: bqml_tutorial.sample_model # [START bigquery_dataframes_bqml_getting_started_tutorial] diff --git a/samples/snippets/clustering_model_test.py b/samples/snippets/clustering_model_test.py index a407fc7805..fec4bbcefd 100644 --- a/samples/snippets/clustering_model_test.py +++ b/samples/snippets/clustering_model_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_clustering_model(): +def test_clustering_model() -> None: # [START bigquery_dataframes_clustering_model] from bigframes.ml.cluster import KMeans import bigframes.pandas as bpd diff --git a/samples/snippets/conftest.py b/samples/snippets/conftest.py index d34837b3e2..9171ac78a4 100644 --- a/samples/snippets/conftest.py +++ b/samples/snippets/conftest.py @@ -46,7 +46,7 @@ def project_id(bigquery_client: bigquery.Client) -> str: @pytest.fixture(autouse=True) -def reset_session(): +def reset_session() -> None: """An autouse fixture ensuring each sample runs in a fresh session. This allows us to have samples that query data in different locations. diff --git a/samples/snippets/create_kmeans_model_test.py b/samples/snippets/create_kmeans_model_test.py index 2429060d09..32ebc60a69 100644 --- a/samples/snippets/create_kmeans_model_test.py +++ b/samples/snippets/create_kmeans_model_test.py @@ -13,12 +13,14 @@ # limitations under the License. -def test_kmeans_sample(project_id: str, random_model_id_eu: str): +def test_kmeans_sample(project_id: str, random_model_id_eu: str) -> None: your_gcp_project_id = project_id your_model_id = random_model_id_eu # [START bigquery_dataframes_bqml_kmeans] import datetime + import pandas as pd + import bigframes import bigframes.pandas as bpd @@ -92,7 +94,9 @@ def test_kmeans_sample(project_id: str, random_model_id_eu: str): stationstats = merged_df.groupby(["station_name", "isweekday"]).agg( {"duration": ["mean", "count"], "distance_from_city_center": "max"} ) - stationstats.columns = ["duration", "num_trips", "distance_from_city_center"] + stationstats.columns = pd.Index( + ["duration", "num_trips", "distance_from_city_center"] + ) stationstats = stationstats.sort_values( by="distance_from_city_center", ascending=True ).reset_index() diff --git a/samples/snippets/create_multiple_timeseries_forecasting_model.py b/samples/snippets/create_multiple_timeseries_forecasting_model.py index 26fc15595f..b749c37d50 100644 --- a/samples/snippets/create_multiple_timeseries_forecasting_model.py +++ b/samples/snippets/create_multiple_timeseries_forecasting_model.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_multiple_timeseries_forecasting_model(random_model_id): +def test_multiple_timeseries_forecasting_model(random_model_id: str) -> None: your_model_id = random_model_id # [START bigquery_dataframes_bqml_arima_multiple_step_2_visualize] diff --git a/samples/snippets/create_single_timeseries_forecasting_model_test.py b/samples/snippets/create_single_timeseries_forecasting_model_test.py index 5750933713..0c694de2dc 100644 --- a/samples/snippets/create_single_timeseries_forecasting_model_test.py +++ b/samples/snippets/create_single_timeseries_forecasting_model_test.py @@ -13,8 +13,7 @@ # limitations under the License. -def test_create_single_timeseries(): - +def test_create_single_timeseries() -> None: # [START bigquery_dataframes_single_timeseries_forecasting_model_tutorial] import bigframes.pandas as bpd diff --git a/samples/snippets/explore_query_result_test.py b/samples/snippets/explore_query_result_test.py index 5f0ec7d9b6..42f48fd94e 100644 --- a/samples/snippets/explore_query_result_test.py +++ b/samples/snippets/explore_query_result_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bigquery_dataframes_explore_query_result(): +def test_bigquery_dataframes_explore_query_result() -> None: import bigframes.pandas as bpd # [START bigquery_dataframes_explore_query_result] diff --git a/samples/snippets/gemini_model_test.py b/samples/snippets/gemini_model_test.py index 89212875ae..24b4e7d26d 100644 --- a/samples/snippets/gemini_model_test.py +++ b/samples/snippets/gemini_model_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_gemini_text_generator_model(): +def test_gemini_text_generator_model() -> None: # Determine project id, in this case prefer the one set in the environment # variable GOOGLE_CLOUD_PROJECT (if any) import os diff --git a/samples/snippets/gen_ai_model_test.py b/samples/snippets/gen_ai_model_test.py index e4bead0e46..5cdcd6d3a7 100644 --- a/samples/snippets/gen_ai_model_test.py +++ b/samples/snippets/gen_ai_model_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_llm_model(): +def test_llm_model() -> None: # Determine project id, in this case prefer the one set in the environment # variable GOOGLE_CLOUD_PROJECT (if any) import os diff --git a/samples/snippets/load_data_from_bigquery_test.py b/samples/snippets/load_data_from_bigquery_test.py index e4c65688bd..4523eece97 100644 --- a/samples/snippets/load_data_from_bigquery_test.py +++ b/samples/snippets/load_data_from_bigquery_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bigquery_dataframes_load_data_from_bigquery(): +def test_bigquery_dataframes_load_data_from_bigquery() -> None: # [START bigquery_dataframes_load_data_from_bigquery] # Create a DataFrame from a BigQuery table: import bigframes.pandas as bpd diff --git a/samples/snippets/load_data_from_biquery_job_test.py b/samples/snippets/load_data_from_biquery_job_test.py index 9a7793a7e5..4f1ddc062f 100644 --- a/samples/snippets/load_data_from_biquery_job_test.py +++ b/samples/snippets/load_data_from_biquery_job_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bigquery_dataframes_load_data_from_bigquery_job(): +def test_bigquery_dataframes_load_data_from_bigquery_job() -> None: # Determine project id, in this case prefer the one set in the environment # variable GOOGLE_CLOUD_PROJECT (if any) import os diff --git a/samples/snippets/load_data_from_csv_test.py b/samples/snippets/load_data_from_csv_test.py index 31ab9255bf..cc96b92fb8 100644 --- a/samples/snippets/load_data_from_csv_test.py +++ b/samples/snippets/load_data_from_csv_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bigquery_dataframes_load_data_from_csv(): +def test_bigquery_dataframes_load_data_from_csv() -> None: # [START bigquery_dataframes_load_data_from_csv] import bigframes.pandas as bpd diff --git a/samples/snippets/noxfile.py b/samples/snippets/noxfile.py new file mode 100644 index 0000000000..c36d5f2d81 --- /dev/null +++ b/samples/snippets/noxfile.py @@ -0,0 +1,292 @@ +# Copyright 2019 Google LLC +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from __future__ import print_function + +import glob +import os +from pathlib import Path +import sys +from typing import Callable, Dict, Optional + +import nox + +# WARNING - WARNING - WARNING - WARNING - WARNING +# WARNING - WARNING - WARNING - WARNING - WARNING +# DO NOT EDIT THIS FILE EVER! +# WARNING - WARNING - WARNING - WARNING - WARNING +# WARNING - WARNING - WARNING - WARNING - WARNING + +BLACK_VERSION = "black==22.3.0" +ISORT_VERSION = "isort==5.10.1" + +# Copy `noxfile_config.py` to your directory and modify it instead. + +# `TEST_CONFIG` dict is a configuration hook that allows users to +# modify the test configurations. The values here should be in sync +# with `noxfile_config.py`. Users will copy `noxfile_config.py` into +# their directory and modify it. + +TEST_CONFIG = { + # You can opt out from the test for specific Python versions. + "ignored_versions": [], + # Old samples are opted out of enforcing Python type hints + # All new samples should feature them + "enforce_type_hints": False, + # An envvar key for determining the project id to use. Change it + # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a + # build specific Cloud project. You can also use your own string + # to use your own Cloud project. + "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", + # 'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT', + # If you need to use a specific version of pip, + # change pip_version_override to the string representation + # of the version number, for example, "20.2.4" + "pip_version_override": None, + # A dictionary you want to inject into your test. Don't put any + # secrets here. These values will override predefined values. + "envs": {}, +} + + +try: + # Ensure we can import noxfile_config in the project's directory. + sys.path.append(".") + from noxfile_config import TEST_CONFIG_OVERRIDE +except ImportError as e: + print("No user noxfile_config found: detail: {}".format(e)) + TEST_CONFIG_OVERRIDE = {} + +# Update the TEST_CONFIG with the user supplied values. +TEST_CONFIG.update(TEST_CONFIG_OVERRIDE) + + +def get_pytest_env_vars() -> Dict[str, str]: + """Returns a dict for pytest invocation.""" + ret = {} + + # Override the GCLOUD_PROJECT and the alias. + env_key = TEST_CONFIG["gcloud_project_env"] + # This should error out if not set. + ret["GOOGLE_CLOUD_PROJECT"] = os.environ[env_key] + + # Apply user supplied envs. + ret.update(TEST_CONFIG["envs"]) + return ret + + +# DO NOT EDIT - automatically generated. +# All versions used to test samples. +ALL_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] + +# Any default versions that should be ignored. +IGNORED_VERSIONS = TEST_CONFIG["ignored_versions"] + +TESTED_VERSIONS = sorted([v for v in ALL_VERSIONS if v not in IGNORED_VERSIONS]) + +INSTALL_LIBRARY_FROM_SOURCE = os.environ.get("INSTALL_LIBRARY_FROM_SOURCE", False) in ( + "True", + "true", +) + +# Error if a python version is missing +nox.options.error_on_missing_interpreters = True + +# +# Style Checks +# + + +# Linting with flake8. +# +# We ignore the following rules: +# E203: whitespace before ‘:’ +# E266: too many leading ‘#’ for block comment +# E501: line too long +# I202: Additional newline in a section of imports +# +# We also need to specify the rules which are ignored by default: +# ['E226', 'W504', 'E126', 'E123', 'W503', 'E24', 'E704', 'E121'] +FLAKE8_COMMON_ARGS = [ + "--show-source", + "--builtin=gettext", + "--max-complexity=20", + "--exclude=.nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py", + "--ignore=E121,E123,E126,E203,E226,E24,E266,E501,E704,W503,W504,I202", + "--max-line-length=88", +] + + +@nox.session +def lint(session: nox.sessions.Session) -> None: + if not TEST_CONFIG["enforce_type_hints"]: + session.install("flake8") + else: + session.install("flake8", "flake8-annotations") + + args = FLAKE8_COMMON_ARGS + [ + ".", + ] + session.run("flake8", *args) + + +# +# Black +# + + +@nox.session +def blacken(session: nox.sessions.Session) -> None: + """Run black. Format code to uniform standard.""" + session.install(BLACK_VERSION) + python_files = [path for path in os.listdir(".") if path.endswith(".py")] + + session.run("black", *python_files) + + +# +# format = isort + black +# + + +@nox.session +def format(session: nox.sessions.Session) -> None: + """ + Run isort to sort imports. Then run black + to format code to uniform standard. + """ + session.install(BLACK_VERSION, ISORT_VERSION) + python_files = [path for path in os.listdir(".") if path.endswith(".py")] + + # Use the --fss option to sort imports using strict alphabetical order. + # See https://pycqa.github.io/isort/docs/configuration/options.html#force-sort-within-sections + session.run("isort", "--fss", *python_files) + session.run("black", *python_files) + + +# +# Sample Tests +# + + +PYTEST_COMMON_ARGS = ["--junitxml=sponge_log.xml"] + + +def _session_tests( + session: nox.sessions.Session, post_install: Callable = None +) -> None: + # check for presence of tests + test_list = glob.glob("**/*_test.py", recursive=True) + glob.glob( + "**/test_*.py", recursive=True + ) + test_list.extend(glob.glob("**/tests", recursive=True)) + + if len(test_list) == 0: + print("No tests found, skipping directory.") + return + + if TEST_CONFIG["pip_version_override"]: + pip_version = TEST_CONFIG["pip_version_override"] + session.install(f"pip=={pip_version}") + """Runs py.test for a particular project.""" + concurrent_args = [] + if os.path.exists("requirements.txt"): + if os.path.exists("constraints.txt"): + session.install("-r", "requirements.txt", "-c", "constraints.txt") + else: + session.install("-r", "requirements.txt") + with open("requirements.txt") as rfile: + packages = rfile.read() + + if os.path.exists("requirements-test.txt"): + if os.path.exists("constraints-test.txt"): + session.install("-r", "requirements-test.txt", "-c", "constraints-test.txt") + else: + session.install("-r", "requirements-test.txt") + with open("requirements-test.txt") as rtfile: + packages += rtfile.read() + + if INSTALL_LIBRARY_FROM_SOURCE: + session.install("-e", _get_repo_root()) + + if post_install: + post_install(session) + + if "pytest-parallel" in packages: + concurrent_args.extend(["--workers", "auto", "--tests-per-worker", "auto"]) + elif "pytest-xdist" in packages: + concurrent_args.extend(["-n", "auto"]) + + session.run( + "pytest", + *(PYTEST_COMMON_ARGS + session.posargs + concurrent_args), + # Pytest will return 5 when no tests are collected. This can happen + # on travis where slow and flaky tests are excluded. + # See http://doc.pytest.org/en/latest/_modules/_pytest/main.html + success_codes=[0, 5], + env=get_pytest_env_vars(), + ) + + +@nox.session(python=ALL_VERSIONS) +def py(session: nox.sessions.Session) -> None: + """Runs py.test for a sample using the specified version of Python.""" + if session.python in TESTED_VERSIONS: + _session_tests(session) + else: + session.skip( + "SKIPPED: {} tests are disabled for this sample.".format(session.python) + ) + + +# +# Readmegen +# + + +def _get_repo_root() -> Optional[str]: + """Returns the root folder of the project.""" + # Get root of this repository. Assume we don't have directories nested deeper than 10 items. + p = Path(os.getcwd()) + for i in range(10): + if p is None: + break + if Path(p / ".git").exists(): + return str(p) + # .git is not available in repos cloned via Cloud Build + # setup.py is always in the library's root, so use that instead + # https://github.com/googleapis/synthtool/issues/792 + if Path(p / "setup.py").exists(): + return str(p) + p = p.parent + raise Exception("Unable to detect repository root.") + + +GENERATED_READMES = sorted([x for x in Path(".").rglob("*.rst.in")]) + + +@nox.session +@nox.parametrize("path", GENERATED_READMES) +def readmegen(session: nox.sessions.Session, path: str) -> None: + """(Re-)generates the readme for a sample.""" + session.install("jinja2", "pyyaml") + dir_ = os.path.dirname(path) + + if os.path.exists(os.path.join(dir_, "requirements.txt")): + session.install("-r", os.path.join(dir_, "requirements.txt")) + + in_file = os.path.join(dir_, "README.rst.in") + session.run( + "python", _get_repo_root() + "/scripts/readme-gen/readme_gen.py", in_file + ) diff --git a/samples/snippets/noxfile_config.py b/samples/snippets/noxfile_config.py new file mode 100644 index 0000000000..211d6974b9 --- /dev/null +++ b/samples/snippets/noxfile_config.py @@ -0,0 +1,42 @@ +# Copyright 2020 Google LLC +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Default TEST_CONFIG_OVERRIDE for python repos. + +# You can copy this file into your directory, then it will be inported from +# the noxfile.py. + +# The source of truth: +# https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/noxfile_config.py + +TEST_CONFIG_OVERRIDE = { + # You can opt out from the test for specific Python versions. + "ignored_versions": ["2.7", "3.7", "3.8"], + # Old samples are opted out of enforcing Python type hints + # All new samples should feature them + "enforce_type_hints": True, + # An envvar key for determining the project id to use. Change it + # to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a + # build specific Cloud project. You can also use your own string + # to use your own Cloud project. + "gcloud_project_env": "GOOGLE_CLOUD_PROJECT", + # "gcloud_project_env": "BUILD_SPECIFIC_GCLOUD_PROJECT", + # If you need to use a specific version of pip, + # change pip_version_override to the string representation + # of the version number, for example, "20.2.4" + "pip_version_override": None, + # A dictionary you want to inject into your test. Don't put any + # secrets here. These values will override predefined values. + "envs": {}, +} diff --git a/samples/snippets/pandas_methods_test.py b/samples/snippets/pandas_methods_test.py index bd8e29c003..0f128f9e6a 100644 --- a/samples/snippets/pandas_methods_test.py +++ b/samples/snippets/pandas_methods_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bigquery_dataframes_pandas_methods(): +def test_bigquery_dataframes_pandas_methods() -> None: # [START bigquery_dataframes_pandas_methods] import bigframes.pandas as bpd diff --git a/samples/snippets/quickstart.py b/samples/snippets/quickstart.py index ae3a934004..c26c6f4442 100644 --- a/samples/snippets/quickstart.py +++ b/samples/snippets/quickstart.py @@ -13,7 +13,7 @@ # limitations under the License. -def run_quickstart(project_id: str): +def run_quickstart(project_id: str) -> None: import bigframes session_options = bigframes.BigQueryOptions() diff --git a/samples/snippets/regression_model_test.py b/samples/snippets/regression_model_test.py index 7d1bde689c..43cdabacb4 100644 --- a/samples/snippets/regression_model_test.py +++ b/samples/snippets/regression_model_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_regression_model(): +def test_regression_model() -> None: # [START bigquery_dataframes_regression_model] from bigframes.ml.linear_model import LinearRegression import bigframes.pandas as bpd diff --git a/samples/snippets/remote_function.py b/samples/snippets/remote_function.py index 4db4e67619..c35daf35fc 100644 --- a/samples/snippets/remote_function.py +++ b/samples/snippets/remote_function.py @@ -13,7 +13,7 @@ # limitations under the License. -def run_remote_function_and_read_gbq_function(project_id: str): +def run_remote_function_and_read_gbq_function(project_id: str) -> None: your_gcp_project_id = project_id # [START bigquery_dataframes_remote_function] @@ -51,7 +51,7 @@ def run_remote_function_and_read_gbq_function(project_id: str): str, reuse=False, ) - def get_bucket(num): + def get_bucket(num: float) -> str: if not num: return "NA" boundary = 4000 @@ -96,7 +96,7 @@ def get_bucket(num): reuse=False, packages=["cryptography"], ) - def get_hash(input): + def get_hash(input: str) -> str: from cryptography.fernet import Fernet # handle missing value diff --git a/samples/snippets/remote_function_test.py b/samples/snippets/remote_function_test.py index 8f891274de..24bc7e854e 100644 --- a/samples/snippets/remote_function_test.py +++ b/samples/snippets/remote_function_test.py @@ -12,6 +12,8 @@ # See the License for the specific language governing permissions and # limitations under the License. +import google.api_core.exceptions +import google.cloud.bigquery_connection_v1 import pytest import bigframes.pandas @@ -19,6 +21,35 @@ from . import remote_function +# TODO(tswast): Once the connections are cleaned up in the sample test project +# and https://github.com/GoogleCloudPlatform/python-docs-samples/issues/11720 +# is closed, we shouldn't need this because AFAIK we only use one BQ connection +# in this sample. +@pytest.fixture(autouse=True) +def cleanup_connections() -> None: + client = google.cloud.bigquery_connection_v1.ConnectionServiceClient() + + for conn in client.list_connections( + parent="projects/python-docs-samples-tests/locations/us" + ): + try: + int(conn.name.split("/")[-1].split("-")[0], base=16) + except ValueError: + print(f"Couldn't parse {conn.name}") + continue + + try: + print(f"removing {conn.name}") + client.delete_connection( + google.cloud.bigquery_connection_v1.DeleteConnectionRequest( + {"name": conn.name}, + ) + ) + except google.api_core.exceptions.GoogleAPIError: + # We did as much clean up as we can. + break + + def test_remote_function_and_read_gbq_function( capsys: pytest.CaptureFixture[str], ) -> None: diff --git a/samples/snippets/requirements-test.txt b/samples/snippets/requirements-test.txt new file mode 100644 index 0000000000..62b0c02e79 --- /dev/null +++ b/samples/snippets/requirements-test.txt @@ -0,0 +1,3 @@ +# samples/snippets should be runnable with no "extras" +google-cloud-testutils==1.4.0 +pytest==8.1.1 diff --git a/samples/snippets/requirements.txt b/samples/snippets/requirements.txt new file mode 100644 index 0000000000..1da77c1715 --- /dev/null +++ b/samples/snippets/requirements.txt @@ -0,0 +1,2 @@ +# samples/snippets should be runnable with no "extras" +bigframes==1.4.0 diff --git a/samples/snippets/set_options_test.py b/samples/snippets/set_options_test.py index f981009e9a..3dea524a17 100644 --- a/samples/snippets/set_options_test.py +++ b/samples/snippets/set_options_test.py @@ -13,7 +13,7 @@ # limitations under the License. -def test_bigquery_dataframes_set_options(): +def test_bigquery_dataframes_set_options() -> None: # Close the session before resetting the options import bigframes.pandas as bpd