Skip to content

fix: system test against emulator #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

fix: system test against emulator #2339

merged 2 commits into from
Jul 2, 2025

Conversation

alkatrivedi
Copy link
Contributor

@alkatrivedi alkatrivedi commented Jul 2, 2025 •
edited
Loading

This PR is the fix for failed github action system-test-against-emulator

@alkatrivedi alkatrivedi requested review from a team as code owners July 2, 2025 05:04
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 2, 2025
@alkatrivedi alkatrivedi marked this pull request as draft July 2, 2025 05:04
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Jul 2, 2025
@alkatrivedi alkatrivedi force-pushed the fix-system-test-emulator branch from 1abcc24 to 0114cd7 Compare July 2, 2025 05:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Jul 2, 2025
@alkatrivedi alkatrivedi force-pushed the fix-system-test-emulator branch 2 times, most recently from dbba46f to 1c3bc30 Compare July 2, 2025 06:08
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 2, 2025
@alkatrivedi alkatrivedi force-pushed the fix-system-test-emulator branch 2 times, most recently from c597f5f to c3d3132 Compare July 2, 2025 06:43
@alkatrivedi alkatrivedi force-pushed the fix-system-test-emulator branch from c3d3132 to b75ebf8 Compare July 2, 2025 09:20
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2025
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 2, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2025
@alkatrivedi alkatrivedi marked this pull request as ready for review July 2, 2025 09:24
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Jul 2, 2025
@alkatrivedi alkatrivedi merged commit 2a6af4c into main Jul 2, 2025
21 of 23 checks passed
@alkatrivedi alkatrivedi deleted the fix-system-test-emulator branch July 2, 2025 10:04
@release-please release-please bot mentioned this pull request Jul 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkatrivedi @surbhigarg92 @yoshi-kokoro