Skip to content

Commit 6dd990f

Browse files
fix: GoogleAdsError missing using generator version after 1.3.0 (#908)
[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343
1 parent 3454a51 commit 6dd990f

8 files changed

+16
-0
lines changed

packages/google-cloud-vision/src/v1/image_annotator_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ export class ImageAnnotatorClient {
140140
}
141141
if (!opts.fallback) {
142142
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
143+
} else if (opts.fallback === 'rest') {
144+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
143145
}
144146
if (opts.libName && opts.libVersion) {
145147
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1/product_search_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ export class ProductSearchClient {
155155
}
156156
if (!opts.fallback) {
157157
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
158+
} else if (opts.fallback === 'rest') {
159+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
158160
}
159161
if (opts.libName && opts.libVersion) {
160162
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1p1beta1/image_annotator_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ export class ImageAnnotatorClient {
132132
}
133133
if (!opts.fallback) {
134134
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
135+
} else if (opts.fallback === 'rest') {
136+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
135137
}
136138
if (opts.libName && opts.libVersion) {
137139
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1p2beta1/image_annotator_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ export class ImageAnnotatorClient {
139139
}
140140
if (!opts.fallback) {
141141
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
142+
} else if (opts.fallback === 'rest') {
143+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
142144
}
143145
if (opts.libName && opts.libVersion) {
144146
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1p3beta1/image_annotator_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ export class ImageAnnotatorClient {
140140
}
141141
if (!opts.fallback) {
142142
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
143+
} else if (opts.fallback === 'rest') {
144+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
143145
}
144146
if (opts.libName && opts.libVersion) {
145147
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1p3beta1/product_search_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ export class ProductSearchClient {
155155
}
156156
if (!opts.fallback) {
157157
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
158+
} else if (opts.fallback === 'rest') {
159+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
158160
}
159161
if (opts.libName && opts.libVersion) {
160162
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1p4beta1/image_annotator_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ export class ImageAnnotatorClient {
140140
}
141141
if (!opts.fallback) {
142142
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
143+
} else if (opts.fallback === 'rest') {
144+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
143145
}
144146
if (opts.libName && opts.libVersion) {
145147
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

packages/google-cloud-vision/src/v1p4beta1/product_search_client.ts

+2
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ export class ProductSearchClient {
159159
}
160160
if (!opts.fallback) {
161161
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
162+
} else if (opts.fallback === 'rest') {
163+
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
162164
}
163165
if (opts.libName && opts.libVersion) {
164166
clientHeader.push(`${opts.libName}/${opts.libVersion}`);

0 commit comments

Comments
 (0)