getColumnFamiles() {
- return columnFamilies.values();
- }
-
- @Override
- public String toString() {
- return MoreObjects.toStringHelper(this)
- .add("tableName", tableName)
- .add("clusterStates", getClusterStates())
- .add("columnFamiles", getColumnFamiles())
- .toString();
- }
- }
-
- /** Wrapper for {@link ClusterState} protocol buffer object */
- public static final class ClusterState {
- private final String id;
- private final ReplicationState replicationState;
-
- private ClusterState(String id, com.google.bigtable.admin.v2.Table.ClusterState clusterState) {
- this.id = id;
- replicationState = clusterState.getReplicationState();
- }
-
- /**
- * Gets the cluster Id
- */
- public String getId() {
- return id;
- }
-
- /**
- * Gets the ReplicationState of the table for this cluster
- */
- public ReplicationState getReplicationState() {
- return replicationState;
- }
-
- @Override
- public String toString() {
- return MoreObjects.toStringHelper(this)
- .add("is", id)
- .add("replicationState", replicationState)
- .toString();
- }
- }
-
- /** Wrapper for {@link ColumnFamily} protocol buffer object */
- public static final class ColumnFamily {
- private final String id;
- private GCRule gCRule = GCRULES.defaultRule();
-
- private ColumnFamily(String id, com.google.bigtable.admin.v2.ColumnFamily cf) {
- Preconditions.checkNotNull(id);
- Preconditions.checkNotNull(cf);
- this.id = id;
-
- if (cf.getGcRule() != null) {
- this.gCRule = convertGcRule(cf.getGcRule());
- }
- }
-
- /**
- * Gets the columnfamily name
- */
- public String getId() {
- return id;
- }
-
- /**
- * Get's the GCRule configured for the columnfamily
- */
- public GCRule getGCRule() {
- return gCRule;
- }
-
- /**
- * Returns true if a GCRule has been configured for the family
- */
- public boolean hasGcRule() {
- return !RuleCase.RULE_NOT_SET.equals(gCRule.toProto().getRuleCase());
- }
-
- @Override
- public String toString() {
- return MoreObjects.toStringHelper(this).add("id", id).add("gCRule", gCRule).toString();
- }
-
- private GCRule convertGcRule(GcRule source) {
- switch (source.getRuleCase()) {
- case MAX_AGE:
- return GCRULES.maxAge(
- Duration.ofSeconds(source.getMaxAge().getSeconds(), source.getMaxAge().getNanos()));
-
- case MAX_NUM_VERSIONS:
- return GCRULES.maxVersions(source.getMaxNumVersions());
-
- case INTERSECTION:
- IntersectionRule intersection = GCRules.GCRULES.intersection();
- for (GcRule rule : source.getIntersection().getRulesList()) {
- intersection.rule(convertGcRule(rule));
- }
- return intersection;
-
- case UNION:
- UnionRule union = GCRules.GCRULES.union();
- for (GcRule rule : source.getUnion().getRulesList()) {
- union.rule(convertGcRule(rule));
- }
- return union;
-
- default:
- return GCRULES.defaultRule();
- }
- }
- }
-
- /**
- * Wrapper for {@link GenerateConsistencyTokenResponse#getConsistencyToken()}
- *
- * Cannot be created. They are obtained by invoking {@link
- * BigtableTableAdminClient#generateConsistencyToken(String)}
- */
- public static final class ConsistencyToken {
- private final String token;
-
- private ConsistencyToken(GenerateConsistencyTokenResponse resp) {
- this.token = resp.getConsistencyToken();
- }
-
- @InternalApi
- public CheckConsistencyRequest toProto(String tableName) {
- return CheckConsistencyRequest.newBuilder()
- .setName(tableName)
- .setConsistencyToken(token)
- .build();
- }
-
- @VisibleForTesting
- String getToken() {
- return token;
- }
-
- @Override
- public String toString() {
- return MoreObjects.toStringHelper(this).add("token", token).toString();
- }
- }
-}
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
index d11b3f6d5695..38d078b115d9 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
@@ -31,7 +31,6 @@
import com.google.api.gax.rpc.UnaryCallable;
import com.google.bigtable.admin.v2.CheckConsistencyRequest;
import com.google.bigtable.admin.v2.CheckConsistencyResponse;
-import com.google.bigtable.admin.v2.CreateTableRequest;
import com.google.bigtable.admin.v2.DeleteTableRequest;
import com.google.bigtable.admin.v2.DropRowRangeRequest;
import com.google.bigtable.admin.v2.GenerateConsistencyTokenRequest;
@@ -40,13 +39,11 @@
import com.google.bigtable.admin.v2.InstanceName;
import com.google.bigtable.admin.v2.ListTablesRequest;
import com.google.bigtable.admin.v2.ListTablesResponse;
-import com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest;
import com.google.bigtable.admin.v2.Table;
import com.google.bigtable.admin.v2.TableName;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminRequests;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminRequests.CreateTable;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminRequests.ModifyFamilies;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminResponses.ConsistencyToken;
+import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest;
+import com.google.cloud.bigtable.admin.v2.models.ModifyColumnFamiliesRequest;
+import com.google.cloud.bigtable.admin.v2.models.ConsistencyToken;
import com.google.cloud.bigtable.admin.v2.stub.BigtableTableAdminStub;
import com.google.protobuf.ByteString;
import com.google.protobuf.Empty;
@@ -56,8 +53,8 @@ public class BigtableTableAdminClientTest {
private BigtableTableAdminClient adminClient;
@Mock private BigtableTableAdminStub mockStub;
- @Mock private UnaryCallable mockCreateTableCallable;
- @Mock private UnaryCallable mockModifyTableCallable;
+ @Mock private UnaryCallable mockCreateTableCallable;
+ @Mock private UnaryCallable mockModifyTableCallable;
@Mock private UnaryCallable mockDeleteTableCallable;
@Mock private UnaryCallable mockGetTableCallable;
@Mock private UnaryCallable mockListTableCallable;
@@ -88,12 +85,15 @@ public void setUp() throws Exception {
Table table = Table.newBuilder().build();
ApiFuture futureTable = ApiFutures.immediateFuture(table);
- Mockito.when(mockCreateTableCallable.call(any(CreateTableRequest.class))).thenReturn(table);
- Mockito.when(mockCreateTableCallable.futureCall(any(CreateTableRequest.class)))
+ Mockito.when(mockCreateTableCallable.call(any(com.google.bigtable.admin.v2.CreateTableRequest.class))).thenReturn(table);
+ Mockito.when(mockCreateTableCallable.futureCall(any(
+ com.google.bigtable.admin.v2.CreateTableRequest.class)))
.thenReturn(futureTable);
- Mockito.when(mockModifyTableCallable.call(any(ModifyColumnFamiliesRequest.class)))
+ Mockito.when(mockModifyTableCallable.call(any(
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.class)))
.thenReturn(table);
- Mockito.when(mockModifyTableCallable.futureCall(any(ModifyColumnFamiliesRequest.class)))
+ Mockito.when(mockModifyTableCallable.futureCall(any(
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.class)))
.thenReturn(futureTable);
Mockito.when(mockGetTableCallable.call(any(GetTableRequest.class))).thenReturn(table);
Mockito.when(mockGetTableCallable.futureCall(any(GetTableRequest.class)))
@@ -101,14 +101,14 @@ public void setUp() throws Exception {
}
@Test
- public void close() throws Exception {
+ public void close() {
adminClient.close();
Mockito.verify(mockStub).close();
}
@Test
public void createTable() {
- CreateTable createTableReq = TableAdminRequests.createTable("tableId");
+ CreateTableRequest createTableReq = CreateTableRequest.of("tableId");
adminClient.createTable(createTableReq);
Mockito.verify(mockCreateTableCallable)
.call(createTableReq.toProto(adminClient.getInstanceName()));
@@ -116,7 +116,7 @@ public void createTable() {
@Test
public void createTableAsync() {
- CreateTable createTableReq = TableAdminRequests.createTable("tableId");
+ CreateTableRequest createTableReq = CreateTableRequest.of("tableId");
adminClient.createTableAsync(createTableReq);
Mockito.verify(mockCreateTableCallable)
.futureCall(createTableReq.toProto(adminClient.getInstanceName()));
@@ -124,7 +124,7 @@ public void createTableAsync() {
@Test
public void modifyFamilies() {
- ModifyFamilies modifyFamReq = TableAdminRequests.modifyFamilies("tableId");
+ ModifyColumnFamiliesRequest modifyFamReq = ModifyColumnFamiliesRequest.of("tableId");
adminClient.modifyFamilies(modifyFamReq);
Mockito.verify(mockModifyTableCallable)
.call(modifyFamReq.toProto(adminClient.getInstanceName()));
@@ -132,7 +132,7 @@ public void modifyFamilies() {
@Test
public void modifyFamiliesAsync() {
- ModifyFamilies modifyFamReq = TableAdminRequests.modifyFamilies("tableId");
+ ModifyColumnFamiliesRequest modifyFamReq = ModifyColumnFamiliesRequest.of("tableId");
adminClient.modifyFamiliesAsync(modifyFamReq);
Mockito.verify(mockModifyTableCallable)
.futureCall(modifyFamReq.toProto(adminClient.getInstanceName()));
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
index d4805ed51eb3..19d28b892978 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
@@ -28,11 +28,10 @@
import com.google.cloud.bigtable.admin.v2.models.GCRules.IntersectionRule;
import com.google.cloud.bigtable.admin.v2.models.GCRules.UnionRule;
import com.google.cloud.bigtable.admin.v2.models.GCRules.VersionRule;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminRequests;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminRequests.CreateTable;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminRequests.ModifyFamilies;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminResponses.ConsistencyToken;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminResponses.Table;
+import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest;
+import com.google.cloud.bigtable.admin.v2.models.ModifyColumnFamiliesRequest;
+import com.google.cloud.bigtable.admin.v2.models.ConsistencyToken;
+import com.google.cloud.bigtable.admin.v2.models.Table;
import com.google.protobuf.ByteString;
import java.io.IOException;
import java.util.List;
@@ -79,8 +78,8 @@ public void setup() {
@Test
public void createTable() {
String tableId = "adminCreateTest";
- CreateTable createTableReq =
- TableAdminRequests.createTable(tableId)
+ CreateTableRequest createTableReq =
+ CreateTableRequest.of(tableId)
.addFamily("cf1")
.addFamily("cf2", GCRULES.maxVersions(10))
.addSplit(ByteString.copyFromUtf8("b"))
@@ -91,8 +90,8 @@ public void createTable() {
assertNotNull(tableResponse);
assertEquals(tableId, tableResponse.getTableName().getTable());
assertEquals(2, tableResponse.getColumnFamiles().size());
- assertFalse(tableResponse.getColumnFamiliesMap().get("cf1").hasGcRule());
- assertTrue(tableResponse.getColumnFamiliesMap().get("cf2").hasGcRule());
+ assertFalse(tableResponse.getColumnFamiliesMap().get("cf1").hasGCRule());
+ assertTrue(tableResponse.getColumnFamiliesMap().get("cf2").hasGCRule());
assertEquals(
10,
((VersionRule) tableResponse.getColumnFamiliesMap().get("cf2").getGCRule())
@@ -105,7 +104,7 @@ public void createTable() {
@Test
public void modifyFamilies() {
String tableId = "adminModifyFamTest";
- ModifyFamilies modifyFamiliesReq = TableAdminRequests.modifyFamilies(tableId);
+ ModifyColumnFamiliesRequest modifyFamiliesReq = ModifyColumnFamiliesRequest.of(tableId);
modifyFamiliesReq
.addFamily("mf1")
@@ -130,7 +129,7 @@ public void modifyFamilies() {
.addFamily("mf7");
try {
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
Table tableResponse = tableAdmin.modifyFamilies(modifyFamiliesReq);
assertEquals(5, tableResponse.getColumnFamiles().size());
assertNotNull(tableResponse.getColumnFamiliesMap().get("mf1"));
@@ -169,7 +168,7 @@ public void modifyFamilies() {
@Test
public void deleteTable() {
String tableId = "adminDeleteTest";
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
tableAdmin.deleteTable(tableId);
}
@@ -178,7 +177,7 @@ public void getTable() {
String tableId = "adminGetTest";
try {
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
Table tableResponse = tableAdmin.getTable(tableId);
assertNotNull(tableResponse);
assertEquals(tableId, tableResponse.getTableName().getTable());
@@ -192,7 +191,7 @@ public void listTables() {
String tableId = "adminListTest";
try {
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
List tables = tableAdmin.listTables();
assertNotNull(tables);
assertFalse("List tables did not return any tables", tables.isEmpty());
@@ -206,7 +205,7 @@ public void listTablesAsync() throws Exception {
String tableId = "adminListTest";
try {
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
List tables = tableAdmin.listTablesAsync().get();
assertNotNull(tables);
assertFalse("List tables did not return any tables", tables.isEmpty());
@@ -220,7 +219,7 @@ public void dropRowRange() {
String tableId = "adminDropRowrangeTest";
try {
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
tableAdmin.dropRowRange(tableId, "rowPrefix");
tableAdmin.dropAllRows(tableId);
} finally {
@@ -233,7 +232,7 @@ public void checkConsistency() {
String tableId = "adminConsistencyTest";
try {
- tableAdmin.createTable(TableAdminRequests.createTable(tableId));
+ tableAdmin.createTable(CreateTableRequest.of(tableId));
ConsistencyToken consistencyToken = tableAdmin.generateConsistencyToken(tableId);
assertNotNull(consistencyToken);
boolean consistent = tableAdmin.isConsistent(tableId, consistencyToken);
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyTokenTest.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyTokenTest.java
new file mode 100644
index 000000000000..508bf546c63b
--- /dev/null
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyTokenTest.java
@@ -0,0 +1,37 @@
+/*
+ * Copyright 2018 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.google.cloud.bigtable.admin.v2.models;
+
+import static org.junit.Assert.assertEquals;
+
+import com.google.bigtable.admin.v2.GenerateConsistencyTokenResponse;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+@RunWith(JUnit4.class)
+public class ConsistencyTokenTest {
+ @Test
+ public void fromJsonTest() {
+ ConsistencyToken tokenResponse =
+ ConsistencyToken.fromProto(
+ GenerateConsistencyTokenResponse.newBuilder()
+ .setConsistencyToken("87282hgwd8yg")
+ .build());
+
+ assertEquals("87282hgwd8yg", tokenResponse.getToken());
+ }
+}
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java
index d33940e18f0a..d0538634a2e6 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminRequestsTest.java
@@ -16,18 +16,15 @@
package com.google.cloud.bigtable.admin.v2.models;
import static com.google.common.truth.Truth.assertThat;
+
+import com.google.bigtable.admin.v2.CreateTableRequest.Split;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
-import com.google.bigtable.admin.v2.ColumnFamily;
-import com.google.bigtable.admin.v2.CreateTableRequest;
import com.google.bigtable.admin.v2.GcRule;
import com.google.bigtable.admin.v2.Table;
import com.google.bigtable.admin.v2.TableName;
-import com.google.bigtable.admin.v2.CreateTableRequest.Split;
import com.google.bigtable.admin.v2.InstanceName;
-import com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest;
-import com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.Modification;
import com.google.protobuf.ByteString;
@RunWith(JUnit4.class)
@@ -36,24 +33,23 @@ public class TableAdminRequestsTest {
@Test
public void createTable() {
- CreateTableRequest actual =
- TableAdminRequests.createTable("tableId")
+ com.google.bigtable.admin.v2.CreateTableRequest actual = CreateTableRequest.of("tableId")
.addFamily("cf1")
.addFamily("cf2", GCRules.GCRULES.maxVersions(1))
.addSplit(ByteString.copyFromUtf8("c"))
.toProto(instanceName);
- CreateTableRequest expected =
- CreateTableRequest.newBuilder()
+ com.google.bigtable.admin.v2.CreateTableRequest expected =
+ com.google.bigtable.admin.v2.CreateTableRequest.newBuilder()
.setTableId("tableId")
.setParent(InstanceName.of("project", "instance").toString())
.addInitialSplits(Split.newBuilder().setKey(ByteString.copyFromUtf8("c")))
.setTable(
Table.newBuilder()
- .putColumnFamilies("cf1", ColumnFamily.newBuilder().build())
+ .putColumnFamilies("cf1", com.google.bigtable.admin.v2.ColumnFamily.newBuilder().build())
.putColumnFamilies(
"cf2",
- ColumnFamily.newBuilder()
+ com.google.bigtable.admin.v2.ColumnFamily.newBuilder()
.setGcRule(GCRules.GCRULES.maxVersions(1).toProto())
.build()))
.build();
@@ -63,18 +59,18 @@ public void createTable() {
@Test(expected = NullPointerException.class)
public void createTableRequiredTableId() {
- TableAdminRequests.createTable(null).toProto(instanceName);
+ CreateTableRequest.of(null);
}
@Test(expected = NullPointerException.class)
public void createTableRequiredParent() {
- TableAdminRequests.createTable("tableId").toProto(null);
+ CreateTableRequest.of("tableId").toProto(null);
}
@Test
public void modifyFamilies() {
- ModifyColumnFamiliesRequest actual =
- TableAdminRequests.modifyFamilies("tableId")
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest actual =
+ ModifyColumnFamiliesRequest.of("tableId")
.addFamily("cf1")
.addFamily("cf2", GCRules.GCRULES.maxVersions(1))
.addFamily("cf3")
@@ -82,43 +78,43 @@ public void modifyFamilies() {
.dropFamily("cf3")
.toProto(instanceName);
- ModifyColumnFamiliesRequest expected =
- ModifyColumnFamiliesRequest.newBuilder()
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest expected =
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.newBuilder()
.setName(
TableName.of(instanceName.getProject(), instanceName.getInstance(), "tableId")
.toString())
.addModifications(
- Modification.newBuilder()
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.Modification.newBuilder()
.setId("cf1")
- .setCreate(ColumnFamily.newBuilder().setGcRule(GcRule.getDefaultInstance())))
+ .setCreate(com.google.bigtable.admin.v2.ColumnFamily.newBuilder().setGcRule(GcRule.getDefaultInstance())))
.addModifications(
- Modification.newBuilder()
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.Modification.newBuilder()
.setId("cf2")
.setCreate(
- ColumnFamily.newBuilder()
+ com.google.bigtable.admin.v2.ColumnFamily.newBuilder()
.setGcRule(GCRules.GCRULES.maxVersions(1).toProto())))
.addModifications(
- Modification.newBuilder()
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.Modification.newBuilder()
.setId("cf3")
- .setCreate(ColumnFamily.newBuilder().setGcRule(GcRule.getDefaultInstance())))
+ .setCreate(com.google.bigtable.admin.v2.ColumnFamily.newBuilder().setGcRule(GcRule.getDefaultInstance())))
.addModifications(
- Modification.newBuilder()
+ com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.Modification.newBuilder()
.setId("cf1")
.setUpdate(
- ColumnFamily.newBuilder()
+ com.google.bigtable.admin.v2.ColumnFamily.newBuilder()
.setGcRule(GCRules.GCRULES.maxVersions(5).toProto())))
- .addModifications(Modification.newBuilder().setId("cf3").setDrop(true))
+ .addModifications(com.google.bigtable.admin.v2.ModifyColumnFamiliesRequest.Modification.newBuilder().setId("cf3").setDrop(true))
.build();
assertThat(actual).isEqualTo(expected);
}
@Test(expected = NullPointerException.class)
public void modifyFamiliesRequiredTableId() {
- TableAdminRequests.modifyFamilies(null).toProto(instanceName);
+ ModifyColumnFamiliesRequest.of(null).toProto(instanceName);
}
@Test(expected = NullPointerException.class)
public void modifyFamiliesRequiredParent() {
- TableAdminRequests.modifyFamilies("tableId").toProto(null);
+ ModifyColumnFamiliesRequest.of("tableId").toProto(null);
}
}
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminResponsesTest.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java
similarity index 90%
rename from google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminResponsesTest.java
rename to google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java
index 3b759e2f2954..b2f33b073a1c 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableAdminResponsesTest.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/models/TableTest.java
@@ -30,8 +30,6 @@
import com.google.cloud.bigtable.admin.v2.models.GCRules.IntersectionRule;
import com.google.cloud.bigtable.admin.v2.models.GCRules.UnionRule;
import com.google.cloud.bigtable.admin.v2.models.GCRules.VersionRule;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminResponses.ConsistencyToken;
-import com.google.cloud.bigtable.admin.v2.models.TableAdminResponses.Table;
import com.google.bigtable.admin.v2.GcRule.Intersection;
import com.google.bigtable.admin.v2.GcRule.Union;
import com.google.bigtable.admin.v2.GenerateConsistencyTokenResponse;
@@ -39,7 +37,7 @@
import static com.google.common.truth.Truth.assertThat;
@RunWith(JUnit4.class)
-public class TableAdminResponsesTest {
+public class TableTest {
@Test
public void convertTable() {
@@ -74,7 +72,7 @@ public void convertTable() {
.build())
.build();
- Table tableResponse = TableAdminResponses.convertTable(table);
+ Table tableResponse = Table.fromProto(table);
assertNotNull(tableResponse);
assertEquals(testName, tableResponse.getTableName());
assertEquals(2, tableResponse.getClusterStates().size());
@@ -86,7 +84,7 @@ public void convertTable() {
tableResponse.getClusterStatesMap().get("prod").getReplicationState());
assertEquals(3, tableResponse.getColumnFamiles().size());
assertNotNull("cf1", tableResponse.getColumnFamiliesMap().get("cf1").getId());
- assertFalse(tableResponse.getColumnFamiliesMap().get("cf1").hasGcRule());
+ assertFalse(tableResponse.getColumnFamiliesMap().get("cf1").hasGCRule());
assertThat(GCRULES.defaultRule().toProto())
.isEqualTo(tableResponse.getColumnFamiliesMap().get("cf1").getGCRule().toProto());
@@ -136,10 +134,10 @@ public void convertTableUnionOfIntersections() {
.putColumnFamilies("cf3", ColumnFamily.newBuilder().setGcRule(expected).build())
.build();
- Table tableResponse = TableAdminResponses.convertTable(table);
+ Table tableResponse = Table.fromProto(table);
assertThat(actual)
.isEqualTo(tableResponse.getColumnFamiliesMap().get("cf3").getGCRule().toProto());
- assertTrue(tableResponse.getColumnFamiliesMap().get("cf3").hasGcRule());
+ assertTrue(tableResponse.getColumnFamiliesMap().get("cf3").hasGCRule());
UnionRule parentUnion =
((UnionRule) tableResponse.getColumnFamiliesMap().get("cf3").getGCRule());
@@ -200,7 +198,7 @@ public void convertTableIntersectionOfUnions() {
.putColumnFamilies("cf3", ColumnFamily.newBuilder().setGcRule(expected).build())
.build();
- Table tableResponse = TableAdminResponses.convertTable(table);
+ Table tableResponse = Table.fromProto(table);
assertThat(actual)
.isEqualTo(tableResponse.getColumnFamiliesMap().get("cf3").getGCRule().toProto());
}
@@ -208,22 +206,10 @@ public void convertTableIntersectionOfUnions() {
@Test
public void convertTableEmpty() {
Table tableResponse =
- TableAdminResponses.convertTable(com.google.bigtable.admin.v2.Table.newBuilder().build());
+ Table.fromProto(com.google.bigtable.admin.v2.Table.newBuilder().build());
assertNotNull(tableResponse);
assertEquals(0, tableResponse.getClusterStates().size());
assertEquals(0, tableResponse.getColumnFamiles().size());
}
-
- @Test
- public void convertTokenResponse() {
- ConsistencyToken tokenResponse =
- TableAdminResponses.convertTokenResponse(
- GenerateConsistencyTokenResponse.newBuilder()
- .setConsistencyToken("87282hgwd8yg")
- .build());
-
- assertNotNull(tokenResponse);
- assertEquals("87282hgwd8yg", tokenResponse.getToken());
- }
}