Skip to content

Commit 444650b

Browse files
authored
Revert "Compile on OSX after homebrew update ? (#2031)"
This reverts commit f66cd56.
1 parent c06cc14 commit 444650b

File tree

1 file changed

+14
-17
lines changed

1 file changed

+14
-17
lines changed

scripts/build_gdl.sh

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ WITH_PYTHONVERSION=${WITH_PYTHONVERSION:-ON}
5858
WITH_FFTW=${WITH_FFTW:-ON}
5959
WITH_UDUNITS2=${WITH_UDUNITS2:-ON}
6060
WITH_GLPK=${WITH_GLPK:-ON}
61+
WITH_OPENMP=${WITH_OPENMP:-ON}
6162
if [[ ${BUILD_OS} == "macOS" ]]; then
6263
WITH_HDF4=${WITH_HDF4:-OFF}
6364
WITH_GRIB=${WITH_GRIB:-ON}
@@ -117,13 +118,12 @@ elif [ ${BUILD_OS} == "Linux" ]; then
117118
) # JP 2021 Mar 21: SuSE lacks eccodes
118119
elif [ ${BUILD_OS} == "macOS" ]; then
119120
BREW_PACKAGES=(
120-
libx11 libomp ncurses readline zlib libpng gsl wxwidgets graphicsmagick libtiff libgeotiff netcdf hdf5 fftw proj open-mpi python numpy udunits eigen
121-
eccodes glpk shapelib expat gcc qhull dylibbundler cmake
121+
llvm libx11 libomp ncurses readline zlib libpng gsl wxwidgets graphicsmagick libtiff libgeotiff netcdf hdf5 fftw proj open-mpi python numpy udunits eigen
122+
eccodes glpk shapelib expat gcc@11 qhull dylibbundler cmake
122123
) # JP 2021 Mar 21: HDF4 isn't available - not so critical I guess
123124
# JP 2021 May 25: Added GCC 10 which includes libgfortran, which the numpy tap relies on.
124125
# J-KL 2022 July 30: GCC 10 didn't work with apple silicon mac. So I replaced it with GCC 11
125126
# GD added dylibbundler that simplify building correct apps.
126-
# GD 25/04/2025 see #2025
127127
else
128128
log "Fatal error! Unknown OS: ${BUILD_OS}. This script only supports one of: Windows, Linux, macOS."
129129
exit 1
@@ -432,21 +432,18 @@ function configure_gdl {
432432
fi
433433

434434
if [[ ${BUILD_OS} == "macOS" ]]; then
435-
export OpenMP_ROOT=$(brew --prefix)/opt/libomp
436-
if [[ ${Platform} == "arm64" ]]; then
437-
# see #2025
438-
LDFLAGS="-L/opt/homebrew/opt/libomp/lib -lomp"
439-
OMP_PREPROC='-Xpreprocessor -fopenmp -I/opt/homebrew/opt/libomp/include'
440-
READLINE_DIR='/opt/homebrew/opt/readline'
435+
if [[ ${Platform} == "arm64" ]]; then
436+
export LIBRARY_PATH=$LIBRARY_PATH:/opt/homebrew/opt/llvm/lib
437+
CMAKE_ADDITIONAL_ARGS=( "-DMPI=OFF -DREADLINEDIR=/opt/homebrew/opt/readline"
438+
"-DCMAKE_CXX_COMPILER=/opt/homebrew/opt/llvm/bin/clang++"
439+
"-DCMAKE_C_COMPILER=/opt/homebrew/opt/llvm/bin/clang" )
441440
else
442-
LDFLAGS="-L/usr/local/opt/libomp/lib -lomp"
443-
OMP_PREPROC='-Xpreprocessor -fopenmp -I/usr/local/opt/libomp/include'
444-
READLINE_DIR='/usr/local/opt/readline'
441+
export LIBRARY_PATH=$LIBRARY_PATH:/usr/local/opt/llvm/lib
442+
CMAKE_ADDITIONAL_ARGS=( "-DMPI=OFF -DREADLINEDIR=/usr/local/opt/readline"
443+
"-DCMAKE_CXX_COMPILER=/usr/local/opt/llvm/bin/clang++"
444+
"-DCMAKE_C_COMPILER=/usr/local/opt/llvm/bin/clang" )
445445
fi
446-
CMAKE_ADDITIONAL_ARGS=( "-DMPI=OFF"
447-
"-DREADLINEDIR=${READLINE_DIR}"
448-
'-DOpenMP_CXX_FLAGS=\"${OMP_PREPROC}\"') #avoid blank expansion
449-
fi
446+
fi
450447

451448
# if [[ ${BUILD_OS} != "macOS" ]]; then
452449
# CMAKE_QHULLDIR_OPT="-DQHULLDIR="${ROOT_DIR}"/qhull-2020.2"
@@ -462,7 +459,7 @@ function configure_gdl {
462459
cmake ${GDL_DIR} -G"${GENERATOR}" \
463460
-DCMAKE_BUILD_TYPE=${Configuration} \
464461
-DCMAKE_CXX_FLAGS_RELEASE="-O3 -DNDEBUG" \
465-
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
462+
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} -DOPENMP=${WITH_OPENMP} \
466463
-DWXWIDGETS=${WITH_WXWIDGETS} -DX11={WITH_X11} -DGRAPHICSMAGICK=${WITH_GRAPHICSMAGICK} \
467464
-DNETCDF=${WITH_NETCDF} -DHDF=${WITH_HDF4} -DHDF5=${WITH_HDF5} \
468465
-DMPI=${WITH_MPI} -DTIFF=${WITH_TIFF} -DGEOTIFF=${WITH_GEOTIFF} \

0 commit comments

Comments
 (0)