Skip to content

Fix empty ifs causing errors on spirv 1.6 #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

Vecvec
Copy link
Collaborator

@Vecvec Vecvec commented Jul 5, 2025

Connections
Fixes #7882

Description
Skips if statements if both the accept and reject blocks are empty, they don't do anything so we can just not write them out.

Testing
Adds a snapshot test.

Squash or Rebase?
Squash.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests.
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty if block causes spirv validation errors on spirv 1.6.
2 participants