Skip to content

feat(Reversible Eletrical Robot with proppeler): Created a Pluggin fo… #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gz-sim7
Choose a base branch
from

Conversation

andre-rebelo-teixeira
Copy link

@andre-rebelo-teixeira andre-rebelo-teixeira commented Feb 20, 2025

…r a reversible eletrical motor

Please beware this pluggin does not work by receiving as input the parameters of the mtor and proppeler, but rather the coeficients of a polinomial that converts from input singal (pwm) into thrust and torque exerted

New Feature

Some robots such as the one this plugin was created utilize a reversible electrical motor with a propeller attached, allowing the exertion of thrust in both directions, this was previously not modulated in any plugin so a new plugin was created capable of representing this behavior

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port <FROM_BRANCH> to <TO_BRANCH>

Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/<LATEST_TAG_BRANCH>...<RELEASE_BRANCH>

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Pedro-Roque
Copy link
Contributor

@andre-rebelo-teixeira I'll rework this to fit into the existing multicopter model. I'll come back by the end of the day

@Pedro-Roque Pedro-Roque force-pushed the pr-reversible-eletrical-motor branch 2 times, most recently from 82070e1 to 9b5b8cd Compare March 5, 2025 20:09
@Pedro-Roque
Copy link
Contributor

@ahcorde @azeey Can you chek this PR? We are adding bidirectional motor support to this plugin, as it was missing on the original multicopter plugin.

@andre-rebelo-teixeira andre-rebelo-teixeira marked this pull request as ready for review March 6, 2025 12:06
@Pedro-Roque
Copy link
Contributor

@mjcarroll now ready to review

@iche033
Copy link
Contributor

iche033 commented Mar 14, 2025

I think you mean to target this to gz-sim8? This is currently targeted at gz-sm7 which is Gazebo Garden and has reached EOL. Can you retarget to gz-sim8?

There are also some minor linter issues picked up by CI, e.g. trailing whitespaces and possibly line width limit exceeding 80 chars.

after a quick look through this PR, I think this shouldn't break existing behavior, is that correct?

@Pedro-Roque
Copy link
Contributor

Hi @iche033 , it shouldn't no. We are doing a few more functional tests and then I'll fix the missing CI bits.

@Pedro-Roque Pedro-Roque force-pushed the pr-reversible-eletrical-motor branch from b9e68c2 to 71b775d Compare April 8, 2025 19:29
@Pedro-Roque Pedro-Roque force-pushed the pr-reversible-eletrical-motor branch from 71b775d to 6013fc4 Compare April 8, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

3 participants