Skip to content

Add deletion docs to Journalist Guide #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Add deletion docs to Journalist Guide #156

merged 1 commit into from
Mar 10, 2021

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Feb 18, 2021

Status

Ready for review

Description of Changes

Adds basic information about deletion, including the new options afforded by freedomofpress/securedrop#5770, to the journalist guide.

Resolves #155

Testing

Visual review should be sufficient for a reviewer already familiar with the changes in freedomofpress/securedrop#5770

Release

Expected to be released with SecureDrop 1.8.0.

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

@eloquence eloquence marked this pull request as draft February 18, 2021 02:06
@eloquence eloquence marked this pull request as ready for review February 23, 2021 00:46
@eloquence eloquence requested a review from zenmonkeykstop March 8, 2021 19:10
@emkll emkll self-assigned this Mar 9, 2021
emkll
emkll previously approved these changes Mar 10, 2021
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs updates and screenshots look good to me, a couple of suggestions inline but fine to merge as-is.

----------------------------------------

As part of routine SecureDrop usage, we recommend that you establish data retention
practices consistent with your organization's threat model. Regularly deleting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or perhaps your organization's data lifecycle or retention policies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with:

As part of routine SecureDrop usage, we recommend that you establish data retention
practices consistent with your organization's threat model, data lifecycle and data
retention policies.

If you delete messages and files for a source, the source will continue to appear
in the list of sources in the *Journalist Interface*, and they will still be able
to log into the *Source Interface* using their codename. Consider using this
option if you are not sure that all communication with the source has concluded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or as part of regular maintenance to reduce the disk usage on the server as you move those files to offline storage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went with:

Consider using this option as part of regular deletion of reviewed submissions, especially if you are not sure that all communication with the source has concluded.

(Avoided the reference to offline storage here, because that may require a bit more to unpack for organizations that don't already have such procedures in place -- but I think in future having a recommended data lifecycle section would be a good addition.)

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving based on previous review and visual review of https://github.com/freedomofpress/securedrop-docs/compare/ad337e2..be7da8c

@eloquence eloquence merged commit b5f3aef into main Mar 10, 2021
@legoktm legoktm deleted the safe-deletion branch May 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document changes to source deletion
2 participants