Skip to content

move req files to new dir #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020
Merged

move req files to new dir #1128

merged 1 commit into from
Aug 3, 2020

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Jul 21, 2020

Description

Move requirement file into a requirements directory

Test Plan

  1. delete or .venv

  2. run make venv

  3. activate the newly created environment: source .venv/bin/activate

  4. run the client

    • confirm that you see login window
  5. run make safety

  6. run make update-pip-requirements

  7. run make update-mac-pip-requirements

    • verify that you see the same results as you do on main branch (i will confirm if you don't have a mac - just let me know)
  8. build a debian package from the update-client-reqs-location packaging branch that supports a requirements directory (see support building projects with a requirments dir securedrop-builder#183):

    • package builds without error
    • run that package and confirm that you see login window

Checklist

@kushaldas
Copy link
Contributor

Rebased, I will formally approve after the CI is green, all test steps worked locally.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. 🦄

@kushaldas kushaldas merged commit 514b0ff into main Aug 3, 2020
@kushaldas kushaldas deleted the move-req-files branch August 3, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants