reduce minimum size

[sssoleileraaa]

Description

Fixes #1074, see what it currently looks like:

This PR makes it so the client fits within a 1280x1024 screen when it opens and adds support for a small variation in size in the sourcelist when you change the window size.

Also small fix to the sign-in button so that it no longer does this when you shrink the client to its smallest height. This is what it used to look like:

Known issues that need to be addressed as follow-up or as part of this PR:

• journalist designations vary in size and sometimes don't fit within the smaller window with the current font size, see how the journalist designation gets cut off in the conversation header and reply box:
  
• speech bubbles don't yet vary in size, so you'll have to horizontal scroll, but my thinking is that we'll want to adjust the size of speech bubbles as the window size changes as well. for example, if the window is 1280x1024 then the speech bubbles could look like this:
  

Test Plan

1. Set your screen resolution to 1280 x 1024 and start the client
2. Check that all text, buttons, and widgets fit within the client window
3. Minimize to the client's smallest width and repeat step 2

Regression Test

Also check that the text, buttons, and widgets match what's on the master branch when the client is expanded for a larger screen resolution.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

• I have tested these changes in the appropriate Qubes environment
• I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
• These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

• I have updated the AppArmor profile
• No update to the AppArmor profile is required for these changes
• I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

• I have written a migration and upgraded a test database based on master and confirmed that the migration applies cleanly
• I have written a migration but have not upgraded a test database based on master and would like the reviewer to do so
• I need help writing a database migration
• No database schema changes are needed

[sssoleileraaa]

need to still tweak this to address the bug reported by Nina where the replybox is partially hidden when you double-click the titlebar or click on the max window button in Qubes

please hold off on review for now

[eloquence]

@eloquence to review with @ninavizz

[sssoleileraaa]

(just trying to fix errors around black and isort since those changes were merged into the master branch this morning)

[eloquence]

@ninavizz, @creviera and I discussed this today. Here's where we are:

• In my testing, at the 1368x768 resolution, this PR allows the full client window to fit without horizontal scrolling or truncation. So that's a big improvement from current state, and if there are no other issues in review, this PR is IMO good to land.

• I'll add a separate docs PR to specify this as the minimum supported screen resolution for running the SecureDrop Workstation.

• While lower resolutions than 1368x768 are unlikely, we all agree that the client ideally should support graceful resizing of the client window, regardless of screen resolution. @ninavizz will file a separate issue with recommendations for the preferred resize behavior. I will file a couple of issues for the display of long source designations at lower window sizes. These issues can be prioritized separately from this PR.

[rmol]

I ran through this today and the only potentially undesirable behavior I noticed was a horizontal scrollbar at the bottom of the source list, when running the client at 1280x1024.

[rmol]

And it occurs to me belatedly that I was testing on my cursed main Qubes machine, which has caused other visual variances in the past. 🤦 I should try another system.

[rmol]

Well, my clean and virtuous test Qubes machine also gets the sourcelist scrollbar at 1280x1024. Anyone else see this?

[rmol]

I may have overstated its cleanliness and virtue. I still had a custom DPI value from earlier testing. Resetting to 96 eliminated the scrollbar.

[kushaldas]

I can see a different issue in the initial screen. The world list is getting cut off in the right hand side.

[sssoleileraaa]

We can add a followup issue for supporting custom dpi settings.

As far as what Kushal is seeing as the default client, I'm surprised. On Debian, the inital screen looks like this for me (you can see the close button in the top right and that it fits within a 1280x1024 resolution screen:

If I double click it shrinks to the min width:

In Qubes, I see the same behavior.

[rmol]

As this looks good at default DPI settings, and we're going to address DPI flexibility in another issue, approving.

[sssoleileraaa]

This PR also closes #584