Opens downloaded files when double-clicked as per Qubes recipe. #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I've updated names of |
|
Small note: For open actions, too, we should avoid the double-click pattern and stick to single-click. |
redshiftzero
reviewed
Nov 6, 2018
| # TODO: Set marked as read? | ||
| else: # pragma: no cover | ||
| # Non Qubes OS. Just log the event for now. | ||
| logger.info('Opening file "{}".'.format(message.filename)) |
There was a problem hiding this comment.
message.filename -> source_db_object.filename
This was referenced Nov 6, 2018
legoktm
pushed a commit
that referenced
this pull request
Dec 15, 2023
Update qrexec policy keyword characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #20.
QProcessclass to kick off the new process since it's only marginally simpler than the built-in Python equivalent.is_readattribute via the API? It should be trivial to add this action to this PR, just let me know.