Skip to content

Filter out storybooks in CoreGui #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Conversation

vocksel
Copy link
Collaborator

@vocksel vocksel commented Aug 5, 2023

Problem

When opening flipbook several warnings appear in the output from it attempting to load Roblox-created storybooks in CoreGui

  12:37:42.545  Failed to load storybook CoreGui.RobloxGui.Modules.VoiceChatPrompt.VoiceChatPrompt.storybook. Error: table expected, got nil  -  Edit - useStorybooks:40
  12:37:42.545  Failed to load storybook CoreGui.RobloxGui.Modules.Settings.Settings.storybook. Error: table expected, got nil  -  Edit - useStorybooks:40
  12:37:42.545  Failed to load storybook CoreGui.RobloxGui.Modules.InGameChat.BubbleChat.BubbleChat.storybook. Error: table expected, got nil  -  Edit - useStorybooks:40
  12:37:42.545  Failed to load storybook CoreGui.RobloxGui.Modules.TopBar.TopBar.storybook. Error: table expected, got nil  -  Edit - useStorybooks:40
  12:37:42.545  Failed to load storybook CoreGui.RobloxGui.Modules.ContactList.ContactList.storybook. Error: table expected, got nil  -  Edit - useStorybooks:40

Solution

To fix this, I've updated isStorybookModule to return false for any storybook in CoreGui

Closes #218

Checklist

  • Ran ./bin/test.sh locally before merging

Copy link
Collaborator

@passhley passhley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me, just a few changes

@vocksel vocksel requested a review from passhley August 13, 2023 19:46
@vocksel vocksel merged commit fa5861d into main Nov 19, 2023
@vocksel vocksel deleted the 218-filter-storybooks-in-coregui branch November 19, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complains about CoreGui
2 participants